From nobody Mon Feb 9 03:14:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1638543858; cv=none; d=zohomail.com; s=zohoarc; b=nh885hjlIfi2lQOvLUQxlwpx/opwcvsRRQbMkHIYn0v2WGFNeIb+rH+9yXqGombrjVhENO2uMYx9mBL0m4kX6NMlyZcA3srrnLubVkcDXPmgCuLMFx6NADzkcpuJyUB6On4lCV1h8AzA5hYBQeWziKvRZ0y4fd+V6j7AtPzwP4k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638543858; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A6n5nCY4V+NbwC/OajgJsaAkByftGKbTR0FjmLimnoc=; b=Q6SU+akkaYOL+i43Uo4XFHuMwUaQkDczIrAJ7fIa6yja5tO6NuS6eQOuv2jOo8NE9/UPQd1TR33zliccQiQr7eduAa3Crt3RUr8Uea3i2d4P9VpEEW4tPqTxXyPJkhi0do4lXCuR5axajysoWRrBHwvWyDYuO12nQTZyFiNjg5g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1638543858640164.65131799327116; Fri, 3 Dec 2021 07:04:18 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-390-qzzK9AeUNTiIIUcxSZlV7w-1; Fri, 03 Dec 2021 10:04:15 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3177190A7D2; Fri, 3 Dec 2021 15:04:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 820BA79453; Fri, 3 Dec 2021 15:04:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4BA96180126E; Fri, 3 Dec 2021 15:04:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B3F45FP031222 for ; Fri, 3 Dec 2021 10:04:05 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9613C5ED33; Fri, 3 Dec 2021 15:04:05 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id C60625D9D5 for ; Fri, 3 Dec 2021 15:04:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638543857; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=A6n5nCY4V+NbwC/OajgJsaAkByftGKbTR0FjmLimnoc=; b=GImYepKkTXTjB+z7S7D1A8BSJsy22JzxlgvQt1YpqqrtNc2nVzqbgTz6w7XcVj7r1BbVIV 8T1WQNUfTYNShx60bQKyNiR6M+n4YUa/sp7QtW9zJnGZX0pMmVWWE7i/fXc6vKQb58H7a8 BIEMD4SkfRcavTgwKo9B5AduSHlDw10= X-MC-Unique: qzzK9AeUNTiIIUcxSZlV7w-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 14/17] qemu: migration: Implement VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRITES Date: Fri, 3 Dec 2021 16:01:53 +0100 Message-Id: <7767ec14373d109391848135d5442bca51ec1d5f.1638543496.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1638543859104100005 Content-Type: text/plain; charset="utf-8" Use it to enable the 'write-blocking' mode of 'blockdev-mirror'. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 16 +++++++++++++--- src/qemu/qemu_migration.h | 1 + 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 00c33c869e..e32c5865f9 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -931,7 +931,8 @@ qemuMigrationSrcNBDStorageCopyBlockdev(virQEMUDriver *d= river, const char *socket, unsigned long long mirror_speed, unsigned int mirror_shallow, - const char *tlsAlias) + const char *tlsAlias, + bool syncWrites) { g_autoptr(qemuBlockStorageSourceAttachData) data =3D NULL; qemuDomainDiskPrivate *diskPriv =3D QEMU_DOMAIN_DISK_PRIVATE(disk); @@ -960,7 +961,7 @@ qemuMigrationSrcNBDStorageCopyBlockdev(virQEMUDriver *d= river, mon_ret =3D qemuMonitorBlockdevMirror(qemuDomainGetMonitor(vm), jo= bname, persistjob, sourcename, copysrc->nodeforma= t, mirror_speed, 0, 0, mirror_sha= llow, - false); + syncWrites); if (mon_ret !=3D 0) qemuBlockStorageSourceAttachRollback(qemuDomainGetMonitor(vm), dat= a); @@ -1034,6 +1035,7 @@ qemuMigrationSrcNBDStorageCopyOne(virQEMUDriver *driv= er, const char *jobname =3D NULL; const char *sourcename =3D NULL; bool persistjob =3D false; + bool syncWrites =3D !!(flags & VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRIT= ES); int rc; int ret =3D -1; @@ -1063,7 +1065,8 @@ qemuMigrationSrcNBDStorageCopyOne(virQEMUDriver *driv= er, host, port, socket, mirror_speed, mirror_shallow, - tlsAlias); + tlsAlias, + syncWrites); } else { rc =3D qemuMigrationSrcNBDStorageCopyDriveMirror(driver, vm, diskA= lias, host, port, socket, @@ -2364,6 +2367,13 @@ qemuMigrationSrcBeginPhase(virQEMUDriver *driver, } if (flags & (VIR_MIGRATE_NON_SHARED_DISK | VIR_MIGRATE_NON_SHARED_INC)= ) { + if (flags & VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRITES && + !virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV)) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRITES is= not supported by this QEMU")); + return NULL; + } + if (flags & VIR_MIGRATE_TUNNELLED) { if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", diff --git a/src/qemu/qemu_migration.h b/src/qemu/qemu_migration.h index dd74f8bc88..b233358a51 100644 --- a/src/qemu/qemu_migration.h +++ b/src/qemu/qemu_migration.h @@ -59,6 +59,7 @@ VIR_MIGRATE_POSTCOPY | \ VIR_MIGRATE_TLS | \ VIR_MIGRATE_PARALLEL | \ + VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRITES | \ 0) /* All supported migration parameters and their types. */ --=20 2.31.1