From nobody Mon Feb 9 14:00:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1659444721; cv=none; d=zohomail.com; s=zohoarc; b=W01bHk+Iuq1bp2P9VJtg5D/E57RcQ/QD/jbwUa2iFbsr/TpqNwNx/IlkRO5beNd2eb2ewKFXGZKH8XrK9ejbYuBpEB4F6cB0O342xHKL7Sga0dt6W25x0YDHrKkUWSltWOUEKCd0O7/J9T5Px4yjd1mGRdfMwFFw+c7bSeMTSgM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659444721; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dgeq6BRrKp/uW2v1KGLu4UnNPHsIOPb1jJkEsc6RIxs=; b=migWuhwk/Rywj6r8oLF2PqhEUpZ0p1xgsAFfxjU3DZwYGdjcaVanye/XltjgANZmFNwe23P8cGoZ0t7qB/vKgTIDq2IvF7/dVE+Wa9oeEwwVnUfFXS6s7/ww8y4Xs6mnxjzR9oTPCuytneFIQ+/OEuDT6M1hwhXNH4GLhd4PKxM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1659444721937356.09162958849447; Tue, 2 Aug 2022 05:52:01 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-132-rHo9IojeORWlgNu1Am2YuQ-1; Tue, 02 Aug 2022 08:51:56 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 730F518A651A; Tue, 2 Aug 2022 12:51:54 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5EA8E94580; Tue, 2 Aug 2022 12:51:54 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 350211946A50; Tue, 2 Aug 2022 12:51:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 248D01946A60 for ; Tue, 2 Aug 2022 12:51:53 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E516D492C3B; Tue, 2 Aug 2022 12:51:52 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6FE9C492CA4 for ; Tue, 2 Aug 2022 12:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659444720; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=dgeq6BRrKp/uW2v1KGLu4UnNPHsIOPb1jJkEsc6RIxs=; b=NXXByJOz0yAiqYeWS+gB40+NalD/xzouUkCTysWKcdhkGHvVpOhpevBfujPQsLFXadupAA vsW95O2BaikNGh+k+LyaPYcH2NjlqoTaedqtN9KQnoeswr8vIiwIjaJ5l88OZRjlKENE2k VaI8JpDJskEAhWx7RtNJHYaB/62OG9o= X-MC-Unique: rHo9IojeORWlgNu1Am2YuQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 3/6] qemuMonitorTestNew: Call qemuMonitorOpen with 'retry' false Date: Tue, 2 Aug 2022 14:51:45 +0200 Message-Id: <75b9b3c73c39096a871814bd017e1364859d079b.1659444625.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1659444723322100003 Content-Type: text/plain; charset="utf-8" The 'retry' argument makes the monitor connection opening re-try the connection in case the monitor socket doesn't exist or isn't properly listening. In case of the test code this can't happen because the socket is created and made listening in 'qemuMonitorCommonTestNew' which is called prior to calling 'qemuMonitorOpen'. We can thus avoit the code which attempts retries in monitor connection. Signed-off-by: Peter Krempa --- tests/qemumonitortestutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index 50808f1fb5..1ea8d72711 100644 --- a/tests/qemumonitortestutils.c +++ b/tests/qemumonitortestutils.c @@ -1109,7 +1109,7 @@ qemuMonitorTestNew(virDomainXMLOption *xmlopt, test->qapischema =3D schema; if (!(test->mon =3D qemuMonitorOpen(test->vm, &src, - true, + false, virEventThreadGetContext(test->event= Thread), &qemuMonitorTestCallbacks))) goto error; --=20 2.36.1