From nobody Mon Mar 23 23:25:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1773065807; cv=none; d=zohomail.com; s=zohoarc; b=MmLZ5NHpUN2kA/TZUWJS5RFwouxARRGLGDx+47BCq1byO3iRtZF9HwirRcuBBH27dwjiGAoxbUbJUV32MUrzsBnRqjWA5agdKX8M0hawhHK6fyQqAXl/XtC70FabJICdVUAKVN+glQqC0zMUrKGsnawalQOFioPI55PXbp+PrMc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773065807; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=R/hQeG5sZMeLxhy0t7rjQelKvpDiI+wrp3eaUoc17Tg=; b=KbWwxoGNJuAeoayR7wHx3lTpznSj8nDiyabxrTUXROo2ZYQa9T2ZZuxXGe3E7GNURyzIhzJ5llgePLgDsGFwSw21cmp/odpUht+MeoD49SNpR4KxUKtzrudjXhIhZbo7TxDlbCGzs8INNsYN6fL9j1ASJ/QnFocCIknGf39JJoQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 177306580693326.250756749446055; Mon, 9 Mar 2026 07:16:46 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DAC4441939; Mon, 9 Mar 2026 10:16:45 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 0D5A5419FF; Mon, 9 Mar 2026 10:16:13 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 27897418A5; Mon, 9 Mar 2026 10:16:09 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 60B913FBCB for ; Mon, 9 Mar 2026 10:16:08 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-28-9toNUC7-M9OWf6DgsTjh5g-1; Mon, 09 Mar 2026 10:16:06 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 919711956067 for ; Mon, 9 Mar 2026 14:16:05 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B7C4830001BB for ; Mon, 9 Mar 2026 14:16:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773065768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R/hQeG5sZMeLxhy0t7rjQelKvpDiI+wrp3eaUoc17Tg=; b=aDiScQL6oaVWfkIQ3yK7TbrbysRg05CDDTvBgAjO9P3oBcXFypTSoDI8FZVXxQXHtjL2Op ArrE8Vu/JPjwM37akb4gJkM5PjSYxV1qkYFRDzfPZ/A+PxdFKOCCT/NbjJnV7PXnGvj99O XLMY/UXowLQ1k1XuhrzaZDsv2sJ9j4c= X-MC-Unique: 9toNUC7-M9OWf6DgsTjh5g-1 X-Mimecast-MFC-AGG-ID: 9toNUC7-M9OWf6DgsTjh5g_1773065765 To: devel@lists.libvirt.org Subject: [PATCH] qemu: processShutdownCompletedEvent: Remove inactive VM object after shutdown Date: Mon, 9 Mar 2026 15:16:03 +0100 Message-ID: <7582d28f4d229c40431aad0e71648261c81dedf5.1773065763.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KH3H_Z9nH0RYY9vFnWxqLGFIZj8R7idA06UCKxPRAHg_1773065765 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FHVJFMORCWQ4MJQQJ5QBKLRWEDOY2RCJ X-Message-ID-Hash: FHVJFMORCWQ4MJQQJ5QBKLRWEDOY2RCJ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1773065809874158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa When the qemu process can't be successfully killed (e.g. when it's stuck in a long system call) libvirt creates a watch and waits for the monitor socket to go away before cleaning up the domain. The cleanup code in 'processShutdownCompletedEvent' called 'qemuProcessStop' but didn't call also 'qemuDomainRemoveInactive' which would break if a transient VM would undergo the delayed cleanup as we'd still have it's VM object around. Fixes: e62c26a20dced58ea342d9cb8f5e9164dc3bb023 Closes: https://gitlab.com/libvirt/libvirt/-/work_items/853 Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9e4d0f8640..7d33477636 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4079,6 +4079,7 @@ processShutdownCompletedEvent(virDomainObj *vm) if (virDomainObjIsActive(vm)) { qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_UNKNOWN, VIR_ASYNC_JOB_NONE= , 0); + qemuDomainRemoveInactive(vm, 0, false); } qemuProcessEndStopJob(vm); --=20 2.53.0