[PATCH] conf: schemas: Include 'privatedata.rng' in installed schema files

Peter Krempa posted 1 patch 3 weeks, 6 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/749bc5df33447394a7c491765cfb0f890ed58a37.1667818793.git.pkrempa@redhat.com
src/conf/schemas/meson.build | 1 +
1 file changed, 1 insertion(+)
[PATCH] conf: schemas: Include 'privatedata.rng' in installed schema files
Posted by Peter Krempa 3 weeks, 6 days ago
The privatedata.rng file was accidentally left uninstalled, but it's
referenced by other schema files effectively breaking validation of XMLs
in new installations.

Change to libvirt.spec is not needed as we include all installed schemas
via a wildcard.

Fixes: d8ceacdc87907a3c8656f7ee815ed32f06fe5c7f
Reported-by: "Daniel P. Berrangé" <berrange@redhat.com>
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/conf/schemas/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/conf/schemas/meson.build b/src/conf/schemas/meson.build
index 9ec4c010d6..b293373085 100644
--- a/src/conf/schemas/meson.build
+++ b/src/conf/schemas/meson.build
@@ -19,6 +19,7 @@ schema_files = [
   'nwfilterbinding.rng',
   'nwfilter_params.rng',
   'nwfilter.rng',
+  'privatedata.rng',
   'secret.rng',
   'storagecommon.rng',
   'storagepoolcaps.rng',
-- 
2.37.3

Re: [PATCH] conf: schemas: Include 'privatedata.rng' in installed schema files
Posted by Daniel P. Berrangé 3 weeks, 6 days ago
On Mon, Nov 07, 2022 at 11:59:53AM +0100, Peter Krempa wrote:
> The privatedata.rng file was accidentally left uninstalled, but it's
> referenced by other schema files effectively breaking validation of XMLs
> in new installations.
> 
> Change to libvirt.spec is not needed as we include all installed schemas
> via a wildcard.
> 
> Fixes: d8ceacdc87907a3c8656f7ee815ed32f06fe5c7f
> Reported-by: "Daniel P. Berrangé" <berrange@redhat.com>
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/conf/schemas/meson.build | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|