From nobody Sun Feb 8 20:23:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1554993342; cv=none; d=zoho.com; s=zohoarc; b=Zd/p56jDmAWrsMihtMf3K6YaOXfuI/Qx2X/BXm0EudH8XL9aDVa0x7NzVcRQjM1V1vp/rIH8y2cvCAZZl+TyorrpjXcTSA/CnMtdq8UINLedcz6P70sBX6cvoK8imFcaIyXv7rFfTDc12JOilIDYdLpoWdeo53QQbyBYV3/8bKc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1554993342; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=NGQv5QGx9HoDZxmFKBKmvxVWM8VH5QSMmMKNRyE/gdc=; b=I4k7eogFX03VoTCqEKjvtCv4A5jTraIPFvDG1snwqT3wEE/ctChpPian12mQOWuAL36Fjoe8FrrJ7NJ46FQoZfAF6vo6infHc1n31FJxhBaiqpHJhgXJDEFaQD/oaowWYcuwjor7zb/iXOfkd4nriCPrDh8bfFZFbShhFZ56vgc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1554993342183484.1165683627346; Thu, 11 Apr 2019 07:35:42 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3A6B27F3E2; Thu, 11 Apr 2019 14:35:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0708B5D71F; Thu, 11 Apr 2019 14:35:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A421E3FB10; Thu, 11 Apr 2019 14:35:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3BEZ9fk006406 for ; Thu, 11 Apr 2019 10:35:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 562E71001DEA; Thu, 11 Apr 2019 14:35:09 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id AAFEE1001943; Thu, 11 Apr 2019 14:35:08 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 11 Apr 2019 16:34:58 +0200 Message-Id: <732a965f16ecaa7d4075a5289b00e5ccd298db48.1554993076.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: danielhb413@gmail.com Subject: [libvirt] [PATCH 2/4] qemuhotplugtest: Don't plug a SCSI disk at unit 7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 11 Apr 2019 14:35:41 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Unit number 7 is kind of special. It's reserved for SCSI controller. The comment in virDomainSCSIDriveAddressIsUsed() summarizes that pretty nicely. Libvirt would never generate such address. Signed-off-by: Michal Privoznik --- tests/qemuhotplugtest.c | 2 +- tests/qemuhotplugtestdevices/qemuhotplug-disk-scsi-2.xml | 2 +- ...uhotplug-base-without-scsi-controller-live+disk-scsi-2.xml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index 3eb97d886a..fbf488c54c 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -715,7 +715,7 @@ mymain(void) "device_del", QMP_OK, "human-monitor-command", HMP("")); DO_TEST_DETACH("base-with-scsi-controller-live", "disk-scsi-2", false,= false, - "device_del", QMP_DEVICE_DELETED("scsi3-0-5-7") QMP_OK, + "device_del", QMP_DEVICE_DELETED("scsi3-0-5-6") QMP_OK, "human-monitor-command", HMP("")); =20 DO_TEST_ATTACH("base-live", "qemu-agent", false, true, diff --git a/tests/qemuhotplugtestdevices/qemuhotplug-disk-scsi-2.xml b/tes= ts/qemuhotplugtestdevices/qemuhotplug-disk-scsi-2.xml index 3a847fbda6..876afb182f 100644 --- a/tests/qemuhotplugtestdevices/qemuhotplug-disk-scsi-2.xml +++ b/tests/qemuhotplugtestdevices/qemuhotplug-disk-scsi-2.xml @@ -2,7 +2,7 @@ -
+
diff --git a/tests/qemuhotplugtestdomains/qemuhotplug-base-without-scsi-con= troller-live+disk-scsi-2.xml b/tests/qemuhotplugtestdomains/qemuhotplug-bas= e-without-scsi-controller-live+disk-scsi-2.xml index d35fea6f5f..72b5174825 100644 --- a/tests/qemuhotplugtestdomains/qemuhotplug-base-without-scsi-controller= -live+disk-scsi-2.xml +++ b/tests/qemuhotplugtestdomains/qemuhotplug-base-without-scsi-controller= -live+disk-scsi-2.xml @@ -26,8 +26,8 @@ - -
+ +
--=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list