From nobody Wed Oct 22 12:28:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1759930253; cv=none; d=zohomail.com; s=zohoarc; b=Ndfe4M9TAM1nGEWn2A6BfVCgJ8sPNZgTb6gYkorCCzf/VCOuP5zW9crUDBxisdHOSEEimT0GkDYsFi/RN2f8KZglUXrZnZiGMdn8LhFy0AkcLxBPOSe5/3Dp1f+lqW/3+JOHgPgId1PcPlF4hfsfTMKDR6QTmkyHwJWgQQzWKHY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759930253; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=OuqKvjlqhImPwF9ob8UMocJljRlo1tq8HwtOZb1tVDk=; b=QRpgJKeJ/XpdMTtM9t4bRuNL3qgk3AoLx8ylJVtaZxE3Jax7+vV1OdwDUBU0Z7v61czN/8oji2f7mpIlhGEVIGiHAS9jHKtfZ7XIGpECyojVBxsCeeKywnIFjCgOmKhYaVYds3p5HBjfiLtxZWiIQRMfnojvBPIJdtoA8jXEy1I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1759930253835183.61984009422474; Wed, 8 Oct 2025 06:30:53 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id EF6B641C7E; Wed, 8 Oct 2025 09:30:50 -0400 (EDT) Received: from [172.19.199.17] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 6C98F44AB6; Wed, 8 Oct 2025 09:18:25 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 9E34C441B8; Wed, 8 Oct 2025 08:55:46 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E5C6A44239 for ; Wed, 8 Oct 2025 08:54:35 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-gwTlr4hWNyG1i_4WdcWOJg-1; Wed, 08 Oct 2025 08:54:34 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7CAC61800378 for ; Wed, 8 Oct 2025 12:54:33 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C6B9619560A2 for ; Wed, 8 Oct 2025 12:54:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759928075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OuqKvjlqhImPwF9ob8UMocJljRlo1tq8HwtOZb1tVDk=; b=QA9LgwdhfntZadoTCLvCQ6A5oF573990fj68Y13+rtUkcxhDpu6rlFhsDaoIs8eY5eqjVK daqoegy2igt1yAmMH4WGZ71CkC//zOGuDrRW4YpFrAJ4gmyn9PLX+Ulr0sjWiWu09WPxDC YmiJBYvL1og0twHYiIayegQX9Woms/0= X-MC-Unique: gwTlr4hWNyG1i_4WdcWOJg-1 X-Mimecast-MFC-AGG-ID: gwTlr4hWNyG1i_4WdcWOJg_1759928073 To: devel@lists.libvirt.org Subject: [PATCH v2 24/29] qemu_capabilities: Format and parse new hyperv domcaps members Date: Wed, 8 Oct 2025 14:53:56 +0200 Message-ID: <72917816fb04e751f693c1f00f3852a0d2fae11f.1759927755.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: M21n5CX9bsdSbApZep1C0d1upbyAovBr5FckAmtK9wQ_1759928073 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: HC6WTTCJXWQ5IUBUG5ZGZ4IMC2MZ4JZF X-Message-ID-Hash: HC6WTTCJXWQ5IUBUG5ZGZ4IMC2MZ4JZF X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1759930255460116601 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik After previous commit the virDomainCapsFeatureHyperv struct gained new members. Since virQEMUCaps struct holds a pointer to such struct we must format and parse it to/from capabilities XML. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 42 ++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 2ccddbfcaa..f571596b30 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -4496,6 +4496,7 @@ virQEMUCapsParseHypervCapabilities(virQEMUCaps *qemuC= aps, g_autoptr(virDomainCapsFeatureHyperv) hvcaps =3D NULL; xmlNodePtr n =3D NULL; g_autofree xmlNodePtr *capNodes =3D NULL; + int rc; int ncapNodes; size_t i; =20 @@ -4531,6 +4532,28 @@ virQEMUCapsParseHypervCapabilities(virQEMUCaps *qemu= Caps, VIR_DOMAIN_CAPS_ENUM_SET(hvcaps->features, val); } =20 + rc =3D virXPathUInt("string(./hypervCapabilities/spinlocks)", + ctxt, &hvcaps->spinlocks); + if (rc =3D=3D -2) + return -1; + + rc =3D virXPathTristateSwitch("string(./hypervCapabilities/stimer_dire= ct)", + ctxt, &hvcaps->stimer_direct); + if (rc =3D=3D -2) + return -1; + + rc =3D virXPathTristateSwitch("string(./hypervCapabilities/tlbflush_di= rect)", + ctxt, &hvcaps->tlbflush_direct); + if (rc =3D=3D -2) + return -1; + + rc =3D virXPathTristateSwitch("string(./hypervCapabilities/tlbflush_ex= tended)", + ctxt, &hvcaps->tlbflush_extended); + if (rc =3D=3D -2) + return -1; + + hvcaps->vendor_id =3D virXPathString("string(./hypervCapabilities/vend= or_id)", ctxt); + qemuCaps->hypervCapabilities =3D g_steal_pointer(&hvcaps); return 0; } @@ -5070,6 +5093,25 @@ virQEMUCapsFormatHypervCapabilities(virQEMUCaps *qem= uCaps, virBufferAsprintf(&childBuf, "\n", virDomainHypervTypeToString(i)); } + + if (hvcaps->spinlocks !=3D 0) { + virBufferAsprintf(&childBuf, "%u\n", + hvcaps->spinlocks); + } + if (hvcaps->stimer_direct !=3D VIR_TRISTATE_SWITCH_ABSENT) { + virBufferAsprintf(&childBuf, "%s\n", + virTristateSwitchTypeToString(hvcaps->stimer= _direct)); + } + if (hvcaps->tlbflush_direct !=3D VIR_TRISTATE_SWITCH_ABSENT) { + virBufferAsprintf(&childBuf, "%s\n", + virTristateSwitchTypeToString(hvcaps->tlbflu= sh_direct)); + } + if (hvcaps->tlbflush_extended !=3D VIR_TRISTATE_SWITCH_ABSENT) { + virBufferAsprintf(&childBuf, "%s\n", + virTristateSwitchTypeToString(hvcaps->tlbflu= sh_extended)); + } + virBufferEscapeString(&childBuf, "%s\n", + hvcaps->vendor_id); } =20 return virXMLFormatElement(buf, "hypervCapabilities", &attrBuf, &child= Buf); --=20 2.49.1