From nobody Sun Feb 8 15:01:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1653399325; cv=none; d=zohomail.com; s=zohoarc; b=RhNfHdl+TCJftZ2oh5dnS0wsws9VWAsBed2iU9W4bRE5XatClwiN8PiHEag3HEvQaKQ6NFxXsluPWiIUj9kzS5Fb4VxCC3LLYp6diw5NR6b4TVWjOxsmsdvSXctujQpsXsyZoIpHYCyeyOKIaQwbPUzJJ+i22JmNmVr0KEJp/BQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653399325; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6vixsz8Og+pLhZFkAdJz+iozh3cnMtcQgjyfU9hmnzo=; b=Zco0QGNR1w/mVdDyZTvTXdjc3DOFiw1HW5mHNaI0mdXFVkPpls75QHG3fXw5T+ez7XVaN7b3vtL3aP1Xgn+q6heqBQl2TOVnlOLuI56c3IzFRsBGz8rev/Gfj5B1O7WDadJte1wVs5cPoTiSJ/JFOkVM15W6XcM1ZIYAvFfIGMk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1653399325309165.75268497824152; Tue, 24 May 2022 06:35:25 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-380-wFj57G_jOa-GQfuO627n3A-1; Tue, 24 May 2022 09:35:19 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 333A43C025B0; Tue, 24 May 2022 13:35:16 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0671F492C3B; Tue, 24 May 2022 13:35:16 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BB24C194EB9C; Tue, 24 May 2022 13:35:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 558C9194EB9A for ; Tue, 24 May 2022 13:35:14 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3FB811121315; Tue, 24 May 2022 13:35:14 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FC32112131B for ; Tue, 24 May 2022 13:35:14 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id 17650245B4D; Tue, 24 May 2022 15:35:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653399324; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=6vixsz8Og+pLhZFkAdJz+iozh3cnMtcQgjyfU9hmnzo=; b=JrsedlC0dP9ErK2+Zt9qxCTH12CYpQRoZPEUu6AHcsNY3qV6q/4BtkuAUHZfr5xLnwa3cE rCEgc9ofrchwcP4lq3l77hwZgQqsE+qdABjYQfVJlg5YXpWj2ysy8TxrKTFz6om7uIhTe7 p/UeoZjuZ3LP/CPJYeA5iyLiuhJSt0s= X-MC-Unique: wFj57G_jOa-GQfuO627n3A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Jiri Denemark To: libvir-list@redhat.com Subject: [libvirt PATCH 1/6] qemu: Avoid unlocked access to vm object in monitor callbacks Date: Tue, 24 May 2022 15:35:04 +0200 Message-Id: <725531215b29f0f70e9055a01de93d10fa40ef06.1653399256.git.jdenemar@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1653399325848100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Jiri Denemark --- src/qemu/qemu_process.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 033d3d5bc6..33c3edb9cc 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -145,9 +145,8 @@ qemuProcessHandleAgentEOF(qemuAgent *agent, { qemuDomainObjPrivate *priv; =20 - VIR_DEBUG("Received EOF from agent on %p '%s'", vm, vm->def->name); - virObjectLock(vm); + VIR_DEBUG("Received EOF from agent on %p '%s'", vm, vm->def->name); =20 priv =3D vm->privateData; =20 @@ -186,9 +185,8 @@ qemuProcessHandleAgentError(qemuAgent *agent G_GNUC_UNU= SED, { qemuDomainObjPrivate *priv; =20 - VIR_DEBUG("Received error from agent on %p '%s'", vm, vm->def->name); - virObjectLock(vm); + VIR_DEBUG("Received error from agent on %p '%s'", vm, vm->def->name); =20 priv =3D vm->privateData; =20 @@ -353,9 +351,8 @@ qemuProcessHandleMonitorError(qemuMonitor *mon G_GNUC_U= NUSED, virQEMUDriver *driver =3D opaque; virObjectEvent *event =3D NULL; =20 - VIR_DEBUG("Received error on %p '%s'", vm, vm->def->name); - virObjectLock(vm); + VIR_DEBUG("Received error on %p '%s'", vm, vm->def->name); =20 ((qemuDomainObjPrivate *) vm->privateData)->monError =3D true; event =3D virDomainEventControlErrorNewFromObj(vm); @@ -1773,6 +1770,8 @@ qemuProcessHandleMemoryFailure(qemuMonitor *mon G_GNU= C_UNUSED, virDomainMemoryFailureActionType action; unsigned int flags =3D 0; =20 + virObjectLock(vm); + switch (mfp->recipient) { case QEMU_MONITOR_MEMORY_FAILURE_RECIPIENT_HYPERVISOR: recipient =3D VIR_DOMAIN_EVENT_MEMORY_FAILURE_RECIPIENT_HYPERVISOR; @@ -1809,6 +1808,9 @@ qemuProcessHandleMemoryFailure(qemuMonitor *mon G_GNU= C_UNUSED, flags |=3D VIR_DOMAIN_MEMORY_FAILURE_RECURSIVE; =20 event =3D virDomainEventMemoryFailureNewFromObj(vm, recipient, action,= flags); + + virObjectUnlock(vm); + virObjectEventStateQueue(driver->domainEventState, event); } =20 --=20 2.35.1