From nobody Mon Feb 9 10:49:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1643189392; cv=none; d=zohomail.com; s=zohoarc; b=WF+9Zl9tAQHTjzCAHlOqANcD5ZgJ9esr4LAKpOBLDbg8YK4l2xP7BGHOHgYWODuPu+qzNUyCSyouyxpB3IZV1htucR2RKfX3DeCd4XVWlQyyc/wFa5r25VecoOSnOG2wFSYlnhJ9nSL8Ju72buSph9HQESTEWRAou39nHOfhtDQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643189392; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WnXvZSmPxyprJuy10lh29Z+kFLxlAeS7j1ufdyFoEzc=; b=bGkjY1qEYImM5cuxzfQQ8gyJApz3BtAfeVxqKeO/TbCcTG1UikxtJgyGqn/A3FFRc2cWTMZsLe1XJxDUmBxczJp7x9GgG+oo8yiT5bZpiNjIEgC+MhSh1d1KXjjex2spbUUjEcMJB7BRzQLOPwT5MQ9zYwdtjZOVUTzqj8izGTU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1643189392854765.7219420995084; Wed, 26 Jan 2022 01:29:52 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-275-XeYmDRYQOuS5p7GToPyhwQ-1; Wed, 26 Jan 2022 04:29:50 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AFC6C1006AA8; Wed, 26 Jan 2022 09:29:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8E70A6A901; Wed, 26 Jan 2022 09:29:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5AC804A7CA; Wed, 26 Jan 2022 09:29:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20Q9TOdZ018783 for ; Wed, 26 Jan 2022 04:29:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id 211A962D7C; Wed, 26 Jan 2022 09:29:24 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E8CF62D7B for ; Wed, 26 Jan 2022 09:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643189392; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=WnXvZSmPxyprJuy10lh29Z+kFLxlAeS7j1ufdyFoEzc=; b=Db+/k1CG7B5hDcdy0PBvX8yXwGMNnQqefI8aaPNdiYPLBKN+dNN2g9h5Md90N50TOkwJy2 SDww0fSzQ57dsIrWFlKJg8EMaOFXlspJpXug2lFLeUQP28rgVTk1/vzLDCmjSRkkNtL61u omoczcFSMhRbsIyQVzBugV4e0Em0BAQ= X-MC-Unique: XeYmDRYQOuS5p7GToPyhwQ-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 2/3] qemuDomainAttachHostPCIDevice: Handle hostevs with unassigned type of address Date: Wed, 26 Jan 2022 10:29:09 +0100 Message-Id: <71d692a726897f114f1263d0c46dc598a8c03ed5.1643189237.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1643189394560100001 A can have
which means libvirt manages the device detach from/reattach to the host but the device is never exposed to the guest. This means that we have to take a shortcut during hotplug, similar to the one we are taking when constructing the command line (see qemuBuildHostdevCommandLine()). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=3D2040548 Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_hotplug.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index f36de2385a..b998b51f5a 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1668,6 +1668,12 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver, qemuDomainFillDeviceIsolationGroup(vm->def, &dev); } =20 + if (info->type =3D=3D VIR_DOMAIN_DEVICE_ADDRESS_TYPE_UNASSIGNED) { + /* Unassigned devices are not exposed to QEMU. Our job is done her= e. */ + ret =3D 0; + goto done; + } + if (qemuDomainEnsurePCIAddress(vm, &dev) < 0) goto error; releaseaddr =3D true; @@ -1692,6 +1698,7 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver, exit_monitor: qemuDomainObjExitMonitor(driver, vm); =20 + done: virDomainAuditHostdev(vm, hostdev, "attach", ret =3D=3D 0); if (ret < 0) goto error; --=20 2.34.1