From nobody Sat May 11 18:04:08 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1711030395423112.01739474063993; Thu, 21 Mar 2024 07:13:15 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3CC901D8D; Thu, 21 Mar 2024 10:13:13 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B608A1C82; Thu, 21 Mar 2024 10:12:37 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id BC50C1C65; Thu, 21 Mar 2024 10:12:34 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id CE62B1C30 for ; Thu, 21 Mar 2024 10:12:32 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-4_KJ_bZcMFCKUSoKAxrc9Q-1; Thu, 21 Mar 2024 10:12:31 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C71F2862CAC for ; Thu, 21 Mar 2024 14:12:20 +0000 (UTC) Received: from maggie.brq.redhat.com (unknown [10.43.3.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id 70A83492EF4 for ; Thu, 21 Mar 2024 14:12:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: 4_KJ_bZcMFCKUSoKAxrc9Q-1 From: Michal Privoznik To: devel@lists.libvirt.org Subject: [PATCH] qemu: warn on pausing of guest due to watchdog or io error Date: Thu, 21 Mar 2024 15:12:16 +0100 Message-ID: <71a604fce622efe387d907750f7ad4fe2aa532b7.1711030282.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: GPVRZHIL3LUZQRU5WEVLSGWJ3ZSY6IWY X-Message-ID-Hash: GPVRZHIL3LUZQRU5WEVLSGWJ3ZSY6IWY X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1711030396487100001 From: Lennart Fricke Change the log level for pauses of guests due to watchdog timeouts or io errors from debug to warn to enhance the visibility of such events. Signed-off-by: Lennart Fricke Reviewed-by: Michal Privoznik --- Here's a commit from MR 339 [1] I've merged. 1: https://gitlab.com/libvirt/libvirt/-/merge_requests/339 src/qemu/qemu_process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 8e35d0a73f..8145205fa8 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -790,7 +790,7 @@ qemuProcessHandleWatchdog(qemuMonitor *mon G_GNUC_UNUSE= D, if (action =3D=3D VIR_DOMAIN_EVENT_WATCHDOG_PAUSE && virDomainObjGetState(vm, NULL) =3D=3D VIR_DOMAIN_RUNNING) { qemuDomainObjPrivate *priv =3D vm->privateData; - VIR_DEBUG("Transitioned guest %s to paused state due to watchdog",= vm->def->name); + VIR_WARN("Transitioned guest %s to paused state due to watchdog", = vm->def->name); =20 virDomainObjSetState(vm, VIR_DOMAIN_PAUSED, VIR_DOMAIN_PAUSED_WATC= HDOG); lifecycleEvent =3D virDomainEventLifecycleNewFromObj(vm, @@ -860,7 +860,7 @@ qemuProcessHandleIOError(qemuMonitor *mon G_GNUC_UNUSED, if (action =3D=3D VIR_DOMAIN_EVENT_IO_ERROR_PAUSE && virDomainObjGetState(vm, NULL) =3D=3D VIR_DOMAIN_RUNNING) { qemuDomainObjPrivate *priv =3D vm->privateData; - VIR_DEBUG("Transitioned guest %s to paused state due to IO error",= vm->def->name); + VIR_WARN("Transitioned guest %s to paused state due to IO error", = vm->def->name); =20 if (priv->signalIOError) virDomainObjBroadcast(vm); --=20 2.43.2 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org