From nobody Thu May 9 10:58:33 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1706786277162275.4815157797284; Thu, 1 Feb 2024 03:17:57 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 6E0BA18A9; Thu, 1 Feb 2024 06:17:55 -0500 (EST) Received: from lists.libvirt.org.85.43.8.in-addr.arpa (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 989861AC0; Thu, 1 Feb 2024 06:16:47 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id CD7C61A95; Thu, 1 Feb 2024 06:16:43 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4C7121903 for ; Thu, 1 Feb 2024 06:16:43 -0500 (EST) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-zP-y4krhOoG5cVcrxvcZhQ-1; Thu, 01 Feb 2024 06:16:41 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2E46C3C0EACB for ; Thu, 1 Feb 2024 11:16:41 +0000 (UTC) Received: from orkuz (unknown [10.43.2.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id E84B640C95AD for ; Thu, 1 Feb 2024 11:16:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: zP-y4krhOoG5cVcrxvcZhQ-1 From: Jiri Denemark To: devel@lists.libvirt.org Subject: [libvirt PATCH] conf: Fix error message in virNetworkForwardDefParseXML Date: Thu, 1 Feb 2024 12:16:37 +0100 Message-ID: <70facb04bd995daf3c1aacb3ff9563ef631f0a38.1706786197.git.jdenemar@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: LMPLCT2N7AJIZJXV4DZ6X6SK2URLV6E5 X-Message-ID-Hash: LMPLCT2N7AJIZJXV4DZ6X6SK2URLV6E5 X-MailFrom: jdenemar@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1706786277778100001 Signed-off-by: Jiri Denemark Reviewed-by: Peter Krempa --- src/conf/network_conf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index a2220c05a6..ef3415cd89 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -1362,8 +1362,9 @@ virNetworkForwardDefParseXML(const char *networkName, =20 forwardDev =3D virXPathString("string(./@dev)", ctxt); if (forwardDev && (nForwardAddrs > 0 || nForwardPfs > 0)) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("the 'dev' attribute cannot be used whe= n
or sub-elements are present in network %1$s")); + virReportError(VIR_ERR_XML_ERROR, + _("the 'dev' attribute cannot be used whe= n
or sub-elements are present in network %1$s"), + networkName); return -1; } =20 --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org