From nobody Sun Oct 5 01:49:32 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1757425002; cv=none; d=zohomail.com; s=zohoarc; b=RgXt+UPwtaMJExJ0m/iWP688IMYr6ljPS6FpZfB6atlXpN4NOGINtDYo3DtrcA2/J+WiJZyoZt3TmuYbPfg5p/OqHuINjw8vr5mdtJGo7iGodjUZUa02EO4Oyky+NJOJ8OuvR3w9NmI+i03I+5/FxFNbhyS1rjLf5WBslye0Gdc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757425002; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=gqyG1qfcMESlyOqP9Kg4BhzCcgcKgUEQwNUNMh3ehnY=; b=dvf/gQ9DHwQG/pk1Em29NrIO8etIvpXme4rVVaDXF5BaLr3lO8Q47IDaBMgOvCzmk6uoKc5pabLvIRCf1I4ns8WGFGzOt7+fYJ0DiA0+2mXFYj5HkV2K0EQtSe+70xTI4YrSEauTIEmwU7yP8T1SHDAsu5Ng2rBRmo0Xt3iNkcI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1757425002111638.9379347389392; Tue, 9 Sep 2025 06:36:42 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 1028441B42; Tue, 9 Sep 2025 09:36:41 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id CB9D941B22; Tue, 9 Sep 2025 09:33:07 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 886A3418E3; Tue, 9 Sep 2025 09:32:17 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6768041B0F for ; Tue, 9 Sep 2025 09:32:16 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-ISftLTpkM5-7vk-LwQSvVA-1; Tue, 09 Sep 2025 09:32:14 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 507601956096 for ; Tue, 9 Sep 2025 13:32:13 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 38BD6300018D for ; Tue, 9 Sep 2025 13:32:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757424736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gqyG1qfcMESlyOqP9Kg4BhzCcgcKgUEQwNUNMh3ehnY=; b=L0MXl467D7aAcQi1ChWJ+COIu0O6/FHe+iM63b4as+ljPQweey1AVv9Y6jax84QansTQGG pW/xnT/bTPwQ45qI+xW/SltMtvMhWmU9IphR4U1vjzhtepbnRvtgs8QYwLc5tJO1czGBNA Vqk79B4p25q04T38dAq3K2ZTc69HAlg= X-MC-Unique: ISftLTpkM5-7vk-LwQSvVA-1 X-Mimecast-MFC-AGG-ID: ISftLTpkM5-7vk-LwQSvVA_1757424733 To: devel@lists.libvirt.org Subject: [PATCH 4/4] ch: Implement VIR_DOMAIN_DESTROY_GRACEFUL flag support Date: Tue, 9 Sep 2025 15:32:02 +0200 Message-ID: <6f234030a94ac449118acaeb91ae6c3dc39dc0cc.1757424690.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HDj7IMj_Wg6V0TUcjwWIaJKZV4Oa3kXs3h-XBMyOl8E_1757424733 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EMUFHCOXKBICSIFJ66YMJLTZ3MEFUYRC X-Message-ID-Hash: EMUFHCOXKBICSIFJ66YMJLTZ3MEFUYRC X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1757425004902116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The virDomainDestroyFlags() API has several flags, including VIR_DOMAIN_DESTROY_GRACEFUL which is documented to send only SIGTERM to the emulator process. Implement its support into CH driver. Signed-off-by: Michal Privoznik --- src/ch/ch_driver.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 019994b202..0a516f3384 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -670,9 +670,13 @@ chDomainDestroyFlags(virDomainPtr dom, unsigned int fl= ags) virCHDriver *driver =3D dom->conn->privateData; virDomainObj *vm; virObjectEvent *event =3D NULL; + unsigned int stopFlags =3D 0; int ret =3D -1; =20 - virCheckFlags(0, -1); + virCheckFlags(VIR_DOMAIN_DESTROY_GRACEFUL, -1); + + if (!(flags & VIR_DOMAIN_DESTROY_GRACEFUL)) + stopFlags |=3D VIR_CH_PROCESS_STOP_FORCE; =20 if (!(vm =3D virCHDomainObjFromDomain(dom))) goto cleanup; @@ -687,8 +691,7 @@ chDomainDestroyFlags(virDomainPtr dom, unsigned int fla= gs) goto endjob; =20 if (virCHProcessStop(driver, vm, - VIR_DOMAIN_SHUTOFF_DESTROYED, - VIR_CH_PROCESS_STOP_FORCE) < 0) { + VIR_DOMAIN_SHUTOFF_DESTROYED, stopFlags) < 0) { goto endjob; } =20 --=20 2.49.1