From nobody Thu May 2 01:22:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1496045438919552.1979498526958; Mon, 29 May 2017 01:10:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E652483F40; Mon, 29 May 2017 08:10:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4581360F83; Mon, 29 May 2017 08:10:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D385A180BAF2; Mon, 29 May 2017 08:10:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v4T8AVfo029578 for ; Mon, 29 May 2017 04:10:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5AE1A1822E; Mon, 29 May 2017 08:10:31 +0000 (UTC) Received: from moe.brq.redhat.com (dhcp129-131.brq.redhat.com [10.34.129.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id D7CEF1823E for ; Mon, 29 May 2017 08:10:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E652483F40 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E652483F40 From: Michal Privoznik To: libvir-list@redhat.com Date: Mon, 29 May 2017 10:10:26 +0200 Message-Id: <6e9e1423e1b30e0683f016f830d4b73da8423af4.1496045426.git.mprivozn@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] virCapabilitiesInitCaches: Don't leak @cpus X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 29 May 2017 08:10:36 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The @cpus is allocated by virFileReadValueBitmap() but never freed: =3D=3D21274=3D=3D 40 (32 direct, 8 indirect) bytes in 1 blocks are definite= ly lost in loss record 808 of 1,004 =3D=3D21274=3D=3D at 0x4C2E080: calloc (vg_replace_malloc.c:711) =3D=3D21274=3D=3D by 0x54BA561: virAlloc (viralloc.c:144) =3D=3D21274=3D=3D by 0x54BC604: virBitmapNewEmpty (virbitmap.c:126) =3D=3D21274=3D=3D by 0x54BD059: virBitmapParseUnlimited (virbitmap.c:570) =3D=3D21274=3D=3D by 0x54EECE9: virFileReadValueBitmap (virfile.c:4113) =3D=3D21274=3D=3D by 0x5563132: virCapabilitiesInitCaches (capabilities.= c:1548) =3D=3D21274=3D=3D by 0x2BB86E59: virQEMUCapsInit (qemu_capabilities.c:11= 32) =3D=3D21274=3D=3D by 0x2BBEC067: virQEMUDriverCreateCapabilities (qemu_c= onf.c:928) =3D=3D21274=3D=3D by 0x2BC3DEAA: qemuStateInitialize (qemu_driver.c:845) =3D=3D21274=3D=3D by 0x5625AAC: virStateInitialize (libvirt.c:770) =3D=3D21274=3D=3D by 0x124519: daemonRunStateInit (libvirtd.c:881) =3D=3D21274=3D=3D by 0x554C927: virThreadHelper (virthread.c:206) Signed-off-by: Michal Privoznik --- src/conf/capabilities.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index a91a72a35..43b15761a 100644 --- a/src/conf/capabilities.c +++ b/src/conf/capabilities.c @@ -1643,5 +1643,6 @@ virCapabilitiesInitCaches(virCapsPtr caps) VIR_FREE(path); VIR_DIR_CLOSE(dirp); virCapsHostCacheBankFree(bank); + virBitmapFree(cpus); return ret; } --=20 2.13.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list