From nobody Fri Nov 21 10:14:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1762514888; cv=none; d=zohomail.com; s=zohoarc; b=iaQox0eYBihNKPUixKQwdtmNSQHNVqeWPuLSR1N9ohhTyXg11f84LYjRXTVrTXAW5PMVJetf1MtQkHDdzzgRJANUzvJZROsSmw1Qitz7CT3EnZ3JCMS0nQTlFJphT19BBsZ7mkwPFvtlZRvSxFvY8Mc70Ft8bR1tG8e/Nf9cStI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762514888; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=byAGGBg6pP1NeATdjNA9QhL1gKy0NLdgk8qbVe3hOPQ=; b=TtTJfqiuGA+cHi2dFEeGBZXL4/E/YrPzVxk8p3yC7Jxv2XPmQdVru807o4zeX2rmztVyUVo3MhxOzVfqivSs2B40P97i8GARew5O+CDRYNBHZ8wx66z91KAyKnwxe0tLcTk8l6wDwVzYzPehQ89YBvIdTNCAesv/XRDqjg8tcU4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1762514888892866.2426037383664; Fri, 7 Nov 2025 03:28:08 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 4462541896; Fri, 7 Nov 2025 06:28:08 -0500 (EST) Received: from [172.19.199.29] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 387A241C2F; Fri, 7 Nov 2025 06:26:35 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 1EF0641B1E; Fri, 7 Nov 2025 06:25:07 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B9CF541AB5 for ; Fri, 7 Nov 2025 06:25:05 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-33-ileQRKvxN6-SvGfvHO67-A-1; Fri, 07 Nov 2025 06:25:04 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8B0AF19560B0 for ; Fri, 7 Nov 2025 11:25:03 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D72E818002B6 for ; Fri, 7 Nov 2025 11:25:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762514705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=byAGGBg6pP1NeATdjNA9QhL1gKy0NLdgk8qbVe3hOPQ=; b=V3k8lYXLny7SoHBpL4HN8hLmx13fkHF/FW9TKvbkSPSG0Ivz3/fNi07ooSDjciHgwhFH3A sT33XMtbYjueKmW6lPQDEWeRrhUOGlOdk0mhdX0gasUzp4OWclqwJE0nM8xOfIut/JoyzN eiSq3OYuTPiDgEHk1UF5L/OicIUOrqI= X-MC-Unique: ileQRKvxN6-SvGfvHO67-A-1 X-Mimecast-MFC-AGG-ID: ileQRKvxN6-SvGfvHO67-A_1762514703 To: devel@lists.libvirt.org Subject: [PATCH 1/5] ch_process: Avoid memleak in chProcessAddNetworkDevice() Date: Fri, 7 Nov 2025 12:24:55 +0100 Message-ID: <6be8ae4e1edf7ce827083e41f4a88ebf4820894a.1762514684.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -gWYlZcv524Suiy3Br7gtKKCu_7RJJmMscUpUHtA-GE_1762514703 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BMOWKP4W6H33Z5K5NRLW4IL7CTV3LI7G X-Message-ID-Hash: BMOWKP4W6H33Z5K5NRLW4IL7CTV3LI7G X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1762514890601154100 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The 'payload' variable inside of chProcessAddNetworkDevice() is reused and thus the memory it points to just before its repurpose is not freed. Avoid reusing g_autofree variables. 128 bytes in 1 blocks are definitely lost in loss record 1,828 of 2,026 at 0x491A120: realloc (vg_replace_malloc.c:1801) by 0x4FEC251: g_realloc (in /usr/lib64/libglib-2.0.so.0.8400.4) by 0x500BB7E: g_string_expand (in /usr/lib64/libglib-2.0.so.0.8400.4) by 0x500BBF0: g_string_sized_new (in /usr/lib64/libglib-2.0.so.0.8400.4) by 0x4A114C0: virBufferInitialize (virbuffer.c:121) by 0x4A11890: virBufferAdd (virbuffer.c:160) by 0x4A67344: virJSONValueToBuffer (virjson.c:1562) by 0x4A673DB: virJSONValueToString (virjson.c:1599) by 0xBC878AB: virCHMonitorBuildNetJson (ch_monitor.c:466) by 0xBC8D4A9: chProcessAddNetworkDevice (ch_process.c:688) by 0xBC8FCE2: chDomainAttachDeviceLive (ch_hotplug.c:78) by 0xBC900CA: chDomainAttachDeviceLiveAndUpdateConfig (ch_hotplug.c:174) Signed-off-by: Michal Privoznik --- src/ch/ch_process.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c index a1f30f09e1..4ebb261805 100644 --- a/src/ch/ch_process.c +++ b/src/ch/ch_process.c @@ -637,6 +637,7 @@ chProcessAddNetworkDevice(virCHDriver *driver, g_auto(virBuffer) http_headers =3D VIR_BUFFER_INITIALIZER; g_autofree int *tapfds =3D NULL; g_autofree char *payload =3D NULL; + g_autofree char *netJSONPayload =3D NULL; g_autofree char *response =3D NULL; size_t tapfd_len; size_t payload_len; @@ -685,15 +686,15 @@ chProcessAddNetworkDevice(virCHDriver *driver, } =20 chAssignDeviceNetAlias(vmdef, net); - if (virCHMonitorBuildNetJson(net, &payload) < 0) { + if (virCHMonitorBuildNetJson(net, &netJSONPayload) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Failed to build net json")); return -1; } =20 virBufferAsprintf(&buf, "%s", virBufferCurrentContent(&http_headers)); - virBufferAsprintf(&buf, "Content-Length: %zu\r\n\r\n", strlen(payload)= ); - virBufferAsprintf(&buf, "%s", payload); + virBufferAsprintf(&buf, "Content-Length: %zu\r\n\r\n", strlen(netJSONP= ayload)); + virBufferAddStr(&buf, netJSONPayload); payload_len =3D virBufferUse(&buf); payload =3D virBufferContentAndReset(&buf); =20 --=20 2.51.0