From nobody Mon Feb 9 10:32:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633623970; cv=none; d=zohomail.com; s=zohoarc; b=eY6Clx5b5/JIDO1d37u2jwFZb4r4/wf74h7PguIkwrKZOkikXYB2LfLm2oX0UZcKsdcZQFsXaIv8PMybqlw/05VwZsyroAewooAwFkZoqKoY1nygqF0FO00amVKSN6zvcDE+hZAnnR0VxEPt2XwRemis+4nL/34IdbnbA2TOAus= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633623970; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ScTlsC+APsmmGYEnGF3tZ1R22Vh/jgXZgdjAWJ/DkCg=; b=dSCC0IOMj+1aNmj+kPMWK1Nw1oMMdcwPb0UGwuIu0eoGrQE50VqVUQkdOvoMZUZoRNQ+Vx8k21wBYDc+jl3VBakAcByAPGSfAi5CbU6Zrb97G2Y3ZxA3+XorZp03BWQFbTN+ljbyPIgQRui4UsxCvaQzSqCmjcKlvfPOeV9itDU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1633623969997916.5961431421393; Thu, 7 Oct 2021 09:26:09 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-VeLAIWxQOjiiKB3lybyI9g-1; Thu, 07 Oct 2021 12:26:07 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0DB812CB7FA; Thu, 7 Oct 2021 15:56:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5CC09EA6BF; Thu, 7 Oct 2021 15:56:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B40F04EA38; Thu, 7 Oct 2021 15:56:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 197FL42o024435 for ; Thu, 7 Oct 2021 11:21:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id DFCFF5D6BA; Thu, 7 Oct 2021 15:21:04 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4FA2B5F4E8 for ; Thu, 7 Oct 2021 15:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633623969; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ScTlsC+APsmmGYEnGF3tZ1R22Vh/jgXZgdjAWJ/DkCg=; b=XnEfaxuxo7+PjwyrkqlmOI0+kJWhkHW00QZOxYqT/xMXNmJEgbQN5ORb4ZrgktaWiiuZL4 w6UclnitkONHG6pqoFZk+fL3TQGTc0dqlkOAIC6yWPlHRBlkWqVe9u4GIZAXGuz/brA1mK Xzb7KhYWT7AL+jURvouw5sdSbyVBTJg= X-MC-Unique: VeLAIWxQOjiiKB3lybyI9g-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 083/103] qemu: command: Remove unused qemuBuildRomStr Date: Thu, 7 Oct 2021 17:18:11 +0200 Message-Id: <6bc492de09f09348b3400b601e7205cf74772a0a.1633619630.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633623972119100001 Content-Type: text/plain; charset="utf-8" Now that all users were converted to qemuBuildRomProps we can remove the old code and un-mark qemuBuildRomProps as unused. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 34 +--------------------------------- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 2d47528d53..f6466b3248 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1264,7 +1264,7 @@ qemuBuildVirtioDevStr(virBuffer *buf, } -static int G_GNUC_UNUSED +static int qemuBuildRomProps(virJSONValue *props, virDomainDeviceInfo *info) { @@ -1304,38 +1304,6 @@ qemuBuildRomProps(virJSONValue *props, } -static int G_GNUC_UNUSED -qemuBuildRomStr(virBuffer *buf, - virDomainDeviceInfo *info) -{ - if (info->romenabled || info->rombar || info->romfile) { - /* Passing an empty romfile=3D tells QEMU to disable ROM entirely = for - * this device, and makes other settings irrelevant */ - if (info->romenabled =3D=3D VIR_TRISTATE_BOOL_NO) { - virBufferAddLit(buf, ",romfile=3D"); - return 0; - } - - switch (info->rombar) { - case VIR_TRISTATE_SWITCH_OFF: - virBufferAddLit(buf, ",rombar=3D0"); - break; - case VIR_TRISTATE_SWITCH_ON: - virBufferAddLit(buf, ",rombar=3D1"); - break; - case VIR_TRISTATE_SWITCH_ABSENT: - case VIR_TRISTATE_SWITCH_LAST: - break; - } - if (info->romfile) { - virBufferAddLit(buf, ",romfile=3D"); - virQEMUBuildBufferEscapeComma(buf, info->romfile); - } - } - - return 0; -} - static int qemuBuildIoEventFdStr(virBuffer *buf, virTristateSwitch use, --=20 2.31.1