From nobody Sun Oct 5 01:49:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1757663510; cv=none; d=zohomail.com; s=zohoarc; b=Ek8uXD0O7aAWOpkZGlLIFqI7b9ZqTfpEmkmzomCIUSUSHYlJ+d6+B/RD5e8Fo8h6P2cHkp/NLV18OHagX27c1N39Zwbm/s19kesxr739LZmMvF2fdaCfx+eKaU0WtSE5y4VK37m4g1fJZA1/3GlHYhhNdFg0/YVb1Fe5qNkDjTU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757663510; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=Eb483r59BILbeAvyyFJ/6M8xUyoipn1M4OR9Km0zIB4=; b=IR+JshWOmdvUrHeYUisq5nBqPlXT6ZS0LTPRoDEIAIY+TJyIxR1ON+IoMNJ6qtPgxe4H7gLO2kslT9e0vfRGshLejIWVeYB1JY6K9IL5+6ejgZ+o8+NyUeayaihhZcLvtUNHL7gUlA+wGUhzUWcdfNkLc/QKmp7ifNZ74SCjH1g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1757663510211947.608362980858; Fri, 12 Sep 2025 00:51:50 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 2871041CAC; Fri, 12 Sep 2025 03:51:49 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 662DB41BB1; Fri, 12 Sep 2025 03:50:11 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DBF7C41B1E; Fri, 12 Sep 2025 03:49:52 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 04CC541B1C for ; Fri, 12 Sep 2025 03:49:51 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-22-8WBiijdBNxyf5sxYqUYhTw-1; Fri, 12 Sep 2025 03:49:50 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 886CC1800451 for ; Fri, 12 Sep 2025 07:49:49 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D7340180035E for ; Fri, 12 Sep 2025 07:49:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757663391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eb483r59BILbeAvyyFJ/6M8xUyoipn1M4OR9Km0zIB4=; b=Phr3PO+ShDkrfpD+leCriYtyuKQ30Jw8lakhmm65PM/+SnsbNXc8dAaFhmuKtjwOVp14JJ C0PZPCUHElqUe1cCkRnUp9zBpUzSXGydLy4WyfMHsrXPT2Fx9/9I0Nz/2CnlIaf5LlZJqq rvwTc7A1mDc320s9HN5mfrl2kXVZz20= X-MC-Unique: 8WBiijdBNxyf5sxYqUYhTw-1 X-Mimecast-MFC-AGG-ID: 8WBiijdBNxyf5sxYqUYhTw_1757663389 To: devel@lists.libvirt.org Subject: [PATCH 2/5] ch: Emit event on device attach Date: Fri, 12 Sep 2025 09:49:38 +0200 Message-ID: <6bc0027364efc44b25bb0838c3571f89e497f38b.1757663360.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Uy3h-O8qjO5r3cxDclH9_tfYYzLfrZXxU3I4Kstocw4_1757663389 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: UMG5MB74IKCA6GBWFW2WC4PEKF3CAMF4 X-Message-ID-Hash: UMG5MB74IKCA6GBWFW2WC4PEKF3CAMF4 X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1757663511309116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik When a device is detached from a running guest we ought to emit the VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event. Signed-off-by: Michal Privoznik --- src/ch/ch_hotplug.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/ch/ch_hotplug.c b/src/ch/ch_hotplug.c index e7734e2ff0..b953fe4c6c 100644 --- a/src/ch/ch_hotplug.c +++ b/src/ch/ch_hotplug.c @@ -267,12 +267,15 @@ chDomainRemoveDevice(virDomainObj *vm, =20 =20 static int -chDomainDetachDeviceLive(virDomainObj *vm, +chDomainDetachDeviceLive(virCHDriver *driver, + virDomainObj *vm, virDomainDeviceDef *match) { virDomainDeviceDef detach =3D { .type =3D match->type }; virDomainDeviceInfo *info =3D NULL; virCHDomainObjPrivate *priv =3D vm->privateData; + virObjectEvent *event =3D NULL; + g_autofree char *alias =3D NULL; =20 switch (match->type) { case VIR_DOMAIN_DEVICE_DISK: @@ -339,6 +342,11 @@ chDomainDetachDeviceLive(virDomainObj *vm, return -1; } =20 + /* Save the alias to use when sending a DEVICE_REMOVED event after all + * other tear down is complete. + */ + alias =3D g_strdup(info->alias); + if (virCHMonitorRemoveDevice(priv->monitor, info->alias) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Invalid response from CH. Disk removal failed.")= ); @@ -348,6 +356,9 @@ chDomainDetachDeviceLive(virDomainObj *vm, if (chDomainRemoveDevice(vm, &detach) < 0) return -1; =20 + event =3D virDomainEventDeviceRemovedNewFromObj(vm, alias); + virObjectEventStateQueue(driver->domainEventState, event); + return 0; } =20 @@ -386,7 +397,7 @@ chDomainDetachDeviceLiveAndUpdateConfig(virCHDriver *dr= iver, return -1; } =20 - if (chDomainDetachDeviceLive(vm, dev_live) < 0) { + if (chDomainDetachDeviceLive(driver, vm, dev_live) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Could detach device")); return -1; --=20 2.49.1