From nobody Mon Apr 29 02:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583943621; cv=none; d=zohomail.com; s=zohoarc; b=iAXxyplFHkEzRDXAN+iyZHk5pyg3+CX/cP+5wFc7r5Et11e8p6OfL1946RraFNsedao1bcUcVQ4UsjgMTG5N7/QkR8KnFsSkHDmN54eQ/0DbmDpr3HXnVfnMMgf20xyypQ1BIwFUmr+Jbpv0ri+THQLNJa7faHWcNKtMJ3wkQ2o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583943621; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=7Np9KsOXKjbHZvBpUhY/TQ2U3pnNlqBmjYXHqfid1C8=; b=XoYebcWlbseqEVS1e1BBoZhs4N0ncGPqMWqd+lpCivJYfH0kPr5fWqnJryfM07wN/SyoymTkJxmZPoRE+VLgavS+7xBBXuUlsqn2bGTYvtAI2FQHmWswj7Klw4JIPa5qbr+19qCdJ31f0+VxFTMjsYwucZ3WHie0KNHYJ9lhpso= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 158394362174253.25967139706256; Wed, 11 Mar 2020 09:20:21 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-oEB53JZ3O-aZnhbRI5Z7Kw-1; Wed, 11 Mar 2020 12:20:15 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 378A510883B8; Wed, 11 Mar 2020 16:20:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D02AF8F374; Wed, 11 Mar 2020 16:20:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 32DE818034EA; Wed, 11 Mar 2020 16:20:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02BGK7xa016428 for ; Wed, 11 Mar 2020 12:20:07 -0400 Received: by smtp.corp.redhat.com (Postfix) id 51AF25C1D4; Wed, 11 Mar 2020 16:20:07 +0000 (UTC) Received: from moe.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA53B5C1D8 for ; Wed, 11 Mar 2020 16:20:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583943618; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=7Np9KsOXKjbHZvBpUhY/TQ2U3pnNlqBmjYXHqfid1C8=; b=IWOhpeFESfTbbbmc5nfU0PDfjAjkAfZeuwmRKnaPgEY20UvMJHWeiWQYulBooYu22EMLmX 2PRN/9lDqayvNjQxsQt7kJUX9FRSpotmImuWCOIuOj5ky9bo+gJJLJBtnmsNzGiS9ZERvd SCrS9LnWhHaUuW38h1MjIwml837hgO8= X-MC-Unique: oEB53JZ3O-aZnhbRI5Z7Kw-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] virQEMUCaps: Drop unused usedQMP member Date: Wed, 11 Mar 2020 17:20:00 +0100 Message-Id: <6b4fe3221f99377bfa1c3e982cc2db336b3204f3.1583943600.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The virQEMUCaps structure has usedQMP member which in the past used to tell if qemu we are dealing with is capable of QMP. Well, we don't support HMP anymore (minus a few HMP passthrough commands, which are wrapped into QMP anyways) and the member is not used really. Signed-off-by: Michal Privoznik Reviewed-by: Daniel Henrique Barboza --- src/qemu/qemu_capabilities.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index a75ca0574d..1395549b2b 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -638,7 +638,6 @@ static void virQEMUDomainCapsCacheDispose(void *obj) struct _virQEMUCaps { virObject parent; =20 - bool usedQMP; bool kvmSupportsNesting; =20 char *binary; @@ -1825,7 +1824,6 @@ virQEMUCapsPtr virQEMUCapsNewCopy(virQEMUCapsPtr qemu= Caps) return NULL; =20 ret->invalidation =3D qemuCaps->invalidation; - ret->usedQMP =3D qemuCaps->usedQMP; ret->kvmSupportsNesting =3D qemuCaps->kvmSupportsNesting; =20 ret->ctime =3D qemuCaps->ctime; @@ -4980,7 +4978,6 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps, =20 qemuCaps->version =3D major * 1000000 + minor * 1000 + micro; qemuCaps->package =3D g_steal_pointer(&package); - qemuCaps->usedQMP =3D true; =20 if (virQEMUCapsInitQMPArch(qemuCaps, mon) < 0) return -1; --=20 2.24.1