[PATCH] virQEMUCaps: Drop unused usedQMP member

Michal Privoznik posted 1 patch 4 years ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/6b4fe3221f99377bfa1c3e982cc2db336b3204f3.1583943600.git.mprivozn@redhat.com
src/qemu/qemu_capabilities.c | 3 ---
1 file changed, 3 deletions(-)
[PATCH] virQEMUCaps: Drop unused usedQMP member
Posted by Michal Privoznik 4 years ago
The virQEMUCaps structure has usedQMP member which in the past
used to tell if qemu we are dealing with is capable of QMP. Well,
we don't support HMP anymore (minus a few HMP passthrough
commands, which are wrapped into QMP anyways) and the member is
not used really.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_capabilities.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index a75ca0574d..1395549b2b 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -638,7 +638,6 @@ static void virQEMUDomainCapsCacheDispose(void *obj)
 struct _virQEMUCaps {
     virObject parent;
 
-    bool usedQMP;
     bool kvmSupportsNesting;
 
     char *binary;
@@ -1825,7 +1824,6 @@ virQEMUCapsPtr virQEMUCapsNewCopy(virQEMUCapsPtr qemuCaps)
         return NULL;
 
     ret->invalidation = qemuCaps->invalidation;
-    ret->usedQMP = qemuCaps->usedQMP;
     ret->kvmSupportsNesting = qemuCaps->kvmSupportsNesting;
 
     ret->ctime = qemuCaps->ctime;
@@ -4980,7 +4978,6 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps,
 
     qemuCaps->version = major * 1000000 + minor * 1000 + micro;
     qemuCaps->package = g_steal_pointer(&package);
-    qemuCaps->usedQMP = true;
 
     if (virQEMUCapsInitQMPArch(qemuCaps, mon) < 0)
         return -1;
-- 
2.24.1

Re: [PATCH] virQEMUCaps: Drop unused usedQMP member
Posted by Daniel Henrique Barboza 4 years ago

On 3/11/20 1:20 PM, Michal Privoznik wrote:
> The virQEMUCaps structure has usedQMP member which in the past
> used to tell if qemu we are dealing with is capable of QMP. Well,
> we don't support HMP anymore (minus a few HMP passthrough
> commands, which are wrapped into QMP anyways) and the member is
> not used really.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>