From nobody Mon Feb 9 01:35:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1692986244; cv=none; d=zohomail.com; s=zohoarc; b=agwoiAumEl8S4w8s3UBBR47hXOor1vIPKfsjRor6ZuqNLyqk1145fLWd68EgEKgsrpPP8UdEoIkq6yJs3RG/OlJOm5IyVYllF9ftNgBbm4lraa1WuMgD2BG/cd7gpRBMgPwV897N+qXmMw1x9KZFjEy74CM9OwlG4hfMmgtNOOE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1692986244; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cra0QD7aNWBrA3WXYElgC/9IGDUxiYC8O8CJxRYSX/w=; b=fyiTqnqbMWO6uppHvxxPPoDoBMoRarrjZtVBkWhDVS6oxO2Dj6C34r4y8GS+yohv9TDsjpoNXVsB9o7Q5dZsCiADRG4mYGcdNbfIsJIosmD/mBBxx4SKRzvjJpoC1CaaVhcjilzTC4+H2cTxHyLR1P/hREFjNr3KmS62vxM1eGE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1692986244100405.98864946347203; Fri, 25 Aug 2023 10:57:24 -0700 (PDT) Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-282-tLnCMic_N8mTbkY9lbVVAQ-1; Fri, 25 Aug 2023 13:56:21 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0B0DB38288A3; Fri, 25 Aug 2023 17:56:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECB9F140E962; Fri, 25 Aug 2023 17:56:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CFAE81946A46; Fri, 25 Aug 2023 17:56:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9118F1946A69 for ; Fri, 25 Aug 2023 17:56:09 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 8586F40610B; Fri, 25 Aug 2023 17:56:09 +0000 (UTC) Received: from orca.. (unknown [10.45.225.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D24D403174; Fri, 25 Aug 2023 17:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692986243; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=cra0QD7aNWBrA3WXYElgC/9IGDUxiYC8O8CJxRYSX/w=; b=NZbo9oAFvrVGgE8e8E9/+cv24lVIILDNQb/xop/o/Wdcpu35HUlUhf9ZD6QpsIj4PpazbT jNoKK26XxUGdy3kYdkIrWCGAAGnVQn4GYFmxsegzkkBZtNOO8Rc/c9ozNs7MG0JmO9MOJy NTns7afKWBJcBY2ZoKrGDQcTlWDCXd8= X-MC-Unique: tLnCMic_N8mTbkY9lbVVAQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 33/33] ci: helper: Drop the _make_run method Date: Fri, 25 Aug 2023 19:55:41 +0200 Message-ID: <6ac9d6449d9a6f634d59751f00086b7d65be8c27.1692986130.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1692986245788100001 Content-Type: text/plain; charset="utf-8"; x-default="true" We've successfully migrated over to lcitool to take care of the container workload execution, so dropping this 'make' prep code is a prerequisite of finally getting rid of the ci/Makefile script. Signed-off-by: Erik Skultety Reviewed-by: Daniel P. Berrang=C3=A9 --- ci/helper | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/ci/helper b/ci/helper index 0053fce40e..e45eb63016 100755 --- a/ci/helper +++ b/ci/helper @@ -6,7 +6,6 @@ import argparse import os import pathlib -import pty import subprocess import sys import textwrap @@ -148,30 +147,6 @@ class Application: self._args =3D Parser().parse() self._repo =3D None =20 - def _make_run(self, target): - args =3D [ - "-C", - self._basedir, - target, - ] - - if self._args.action in ["build", "test", "shell"]: - args.extend([ - f"CI_ENGINE=3D{self._args.engine}", - f"CI_USER_LOGIN=3D{self._args.login}", - f"CI_IMAGE_PREFIX=3D{self._args.image_prefix}", - f"CI_IMAGE_TAG=3D{self._args.image_tag}", - ]) - - if self._args.action in ["build", "test"]: - args.extend([ - f"MESON_ARGS=3D{self._args.meson_args}", - f"NINJA_ARGS=3D{self._args.ninja_args}", - ]) - - if pty.spawn(["make"] + args) !=3D 0: - sys.exit("error: 'make' failed") - @staticmethod def _prepare_repo_copy(repo, dest): return repo.clone(dest, local=3DTrue) --=20 2.41.0