From nobody Thu May 2 17:36:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564403009; cv=none; d=zoho.com; s=zohoarc; b=oAicMMre6gPSscJXvNRG5GSDtRoomc65CaTlOxMG9gjBjuInwenMVO2SHt2MI866laBCRC2PZPjuEA8dvy1j237wPgVFhOgpCpwTYCAuBNVqYiERjYrP+VSDhjpUGj4oqjziIRGkMbgp/WVqPUkpA4BkRLvzqpSjAoHfB/zfW30= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564403009; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=+Iz6TNX2q62QYQ8nQMLBbmDE+XGrqIzz+ONYbd1kF1Q=; b=fMee7FNzBJC+sb598CMmjVjWI6crGez3p4X+DlknRiq7oay0Fbf0D26iN+dBHGsk2VFpqD7RfL/JYr5kgZLcO3eu3gqfoJrB2104Y3XnP0LNgABtUPCRYVmqLkqtQZGKDax2HhWHitK6dfZirjy375flju0FWVEFUbRHslGkYr0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1564403009539980.687079000022; Mon, 29 Jul 2019 05:23:29 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4B628308338F; Mon, 29 Jul 2019 12:23:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD93660625; Mon, 29 Jul 2019 12:23:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EAFF21972D; Mon, 29 Jul 2019 12:23:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6TCNQCg026549 for ; Mon, 29 Jul 2019 08:23:26 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6950D60127; Mon, 29 Jul 2019 12:23:26 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id E96E3600F8 for ; Mon, 29 Jul 2019 12:23:23 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Mon, 29 Jul 2019 14:23:14 +0200 Message-Id: <6a63bf17dad7f1b9cd93e663272563d4d71657a0.1564402994.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] qemumonitorjsontest: Don't leak 'query-jobs' info X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Mon, 29 Jul 2019 12:23:28 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The returned array of qemuMonitorJobInfo structs must be freed. 164 (16 direct, 148 indirect) bytes in 1 blocks are definitely lost in loss= record 64 of 84 at 0x4A3568B: realloc (vg_replace_malloc.c:826) by 0x4D888BD: virReallocN (viralloc.c:244) by 0x4D889B3: virExpandN (viralloc.c:293) by 0x4D88C87: virInsertElementsN (viralloc.c:435) by 0x214004: qemuMonitorJSONGetJobInfo (qemu_monitor_json.c:9185) by 0x148B3F: testQueryJobs (qemumonitorjsontest.c:2979) by 0x14C192: virTestRun (testutils.c:174) by 0x14BF36: mymain (qemumonitorjsontest.c:3286) by 0x14E256: virTestMain (testutils.c:1096) by 0x14BFD9: main (qemumonitorjsontest.c:3298) Signed-off-by: Michal Privoznik --- tests/qemumonitorjsontest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index bf89f49aca..522ff5a3d5 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -2996,6 +2996,9 @@ testQueryJobs(const void *opaque) ret =3D 0; =20 cleanup: + for (i =3D 0; i < njobs; i++) + qemuMonitorJobInfoFree(jobs[i]); + VIR_FREE(jobs); qemuMonitorTestFree(test); return ret; } --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list