From nobody Sun May 19 14:32:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1691156302; cv=none; d=zohomail.com; s=zohoarc; b=frsqwqf/wCEWbaCFILYIl8bs6Z00JFLleBmy4pdtjBaVfR3zwn9xd42DQgn1+dsajWnI5eciaaFfGRugcU6MjlSzNz7LxjeWuVSnQCirKq2nxcew0IV6UouDA5Y5d98nPgbGI4E7u9ei531q8co1+Fid/u8FeopOW7bzPgX8VNs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691156302; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=nTUUWluH/IJOh/CDev/RoGWAQWzQrRNDvhJ5mf5p0bw=; b=N357bmuV2/adKMwHMf94AzVcZGJuYej/FVauNgmT8wGcSQ4rlD8Rz9BswcCaMOqQ1C1fYBgLv9t2OAKr8rPK0yZTU/5hCFD3E7+Bc/ySAVTAl0/7qufgWBBGsrUBEmH5jtmTgIi8ziXzEOzo2NW+vrOT4ZPBnp3k+1vN36T1KFs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1691156302321965.0511259897464; Fri, 4 Aug 2023 06:38:22 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-407-_CudZlpHOtKUHcB__4b-9g-1; Fri, 04 Aug 2023 09:38:17 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BDB50185A78F; Fri, 4 Aug 2023 13:38:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F705C5796B; Fri, 4 Aug 2023 13:38:12 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CF891194658F; Fri, 4 Aug 2023 13:38:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B59B1194658D for ; Fri, 4 Aug 2023 13:38:10 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6D163492CA6; Fri, 4 Aug 2023 13:38:10 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 13F2B492B03 for ; Fri, 4 Aug 2023 13:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691156301; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=nTUUWluH/IJOh/CDev/RoGWAQWzQrRNDvhJ5mf5p0bw=; b=ZiKaIykWptXNOCBnt/wG3HJcaE8wMZUVwTFrEEFF2/B862DWEXnLsZX4oD9SR2cVoCMNXy RUO+Kswtv1qjRuksTDykp8y7PojDkS//DXO+n9T14z/Mha7kGl1vJg4pSyrUOcRVm5uRE9 /se3YKVbMNSAeiv5PLNIJFVyCcDcdC0= X-MC-Unique: _CudZlpHOtKUHcB__4b-9g-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] lxc_container: Increase stack size for lxcContainerChild() Date: Fri, 4 Aug 2023 15:38:07 +0200 Message-ID: <69dd2a305fdd99934d65401e5d939b8eca787af8.1691156287.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1691156302767100001 Content-Type: text/plain; charset="utf-8"; x-default="true" When spawning a new container (via clone()) we allocate stack for lxcContainerChild(). So far, we allocate 4 pages for the stack and this used to be enough until we started rewriting everything to glib. With glib we switched to g_strerror() which localizes errno strings and thus increases stack usage, while the previously used strerror_r() was more compact. Fortunately, the solution is easy - just increase how much stack the child can use (16 pages ought to be enough for anybody). Resolves: https://gitlab.com/libvirt/libvirt/-/issues/511 Signed-off-by: Michal Privoznik --- src/lxc/lxc_container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 63cf283285..f741a754ce 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -2132,7 +2132,7 @@ int lxcContainerStart(virDomainDef *def, { pid_t pid; int cflags; - int stacksize =3D getpagesize() * 4; + int stacksize =3D getpagesize() * 16; g_autofree char *stack =3D NULL; char *stacktop; lxc_child_argv_t args =3D { --=20 2.41.0