From nobody Sat May 30 15:30:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1778849741; cv=none; d=zohomail.com; s=zohoarc; b=a7dhV38EAWKHTm1kf7zP9wHz9BhX2w1ZEWIiTfIJALYJRZg85Kv4R76Us4r3/X1tbhuOpkhx2nRbfcEaIPLfOxQllV7E1S2pTZ5BK0sf6qI0VFrQW7OALBuv+gg3Owr15kfisvMTjlWL6mFgAIZC1PI5hMRG6WMNoYXpfxoQh+k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778849741; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=EYQaI4VOFAAqPLRigY4UB+vnCwoN3p0V3xYkwiQSISA=; b=do6KY+PNiymc2Cqm2gQuG8eXkOwUnE3twlODb2H89nDKn/FBSKlOUqkvs7EUWUmVXjqr7jOJaARgWnQG+kM3A1Aj87VarwLsEuKCuIubO+nOBvVHzf3Kjm4sDz3pIx3/qW8IwmtCDAlE32FE9v2sYm7SSsy0Kkym9Ez32+ZtEt8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 177884974193348.35074196410676; Fri, 15 May 2026 05:55:41 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 90F7A418E9; Fri, 15 May 2026 08:55:40 -0400 (EDT) Received: from [172.19.199.12] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 9E85D41A4E; Fri, 15 May 2026 08:54:57 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5DB6F4184D; Fri, 15 May 2026 08:54:50 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4DC5A3FA50 for ; Fri, 15 May 2026 08:54:48 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-332-nq32ktWgPgisGG_Q_xsO8Q-1; Fri, 15 May 2026 08:54:46 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4B238195608E for ; Fri, 15 May 2026 12:54:45 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A91221803A8E for ; Fri, 15 May 2026 12:54:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778849687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EYQaI4VOFAAqPLRigY4UB+vnCwoN3p0V3xYkwiQSISA=; b=TN9ZIR+zY7/FMnGjI25Ht4aPbIm3JDEVc+9LgA0dMH99w3j1osSW5+HqdIeZcDGqAtdQu4 Ff3hkwRHLXi35oUT7KQ7fAJRNTc0Z7S+Fq0GnRgRi0hFEIgBO1NCY3eoNcuEsSgBSjapBg GDI0KJnHF+dB8Q/I4mTUlm4zPS5u/ww= X-MC-Unique: nq32ktWgPgisGG_Q_xsO8Q-1 X-Mimecast-MFC-AGG-ID: nq32ktWgPgisGG_Q_xsO8Q_1778849685 To: devel@lists.libvirt.org Subject: [PATCH] virauth: Verify virConnectAuth::cb is set in virAuthGetPasswordPath() Date: Fri, 15 May 2026 14:54:41 +0200 Message-ID: <69d94e100264a7e79b597411295e5f57859cc865.1778849681.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TtYcVdyACskD7SjPNdM6HgpFkVCzHvG07_QBFv10-XA_1778849685 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6PAGKTNMHENSWBERGO6NYAHHE2D3WHWB X-Message-ID-Hash: 6PAGKTNMHENSWBERGO6NYAHHE2D3WHWB X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1778849745219158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Simirarly to virAuthGetUsernamePath() check whether callback used to collect credentials is actually set before calling it. This bug is easily reproducible, for instance as: int credtype[] =3D { VIR_CRED_PASSPHRASE }; virConnectPtr conn =3D virConnectOpenAuth("esx://root@example.com/", &(virConnectAuth){ .credtype =3D credtype, .ncredtype =3D 1, .cb =3D NULL }, 0); Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/util/virauth.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/util/virauth.c b/src/util/virauth.c index fd4b13de7a..2820220897 100644 --- a/src/util/virauth.c +++ b/src/util/virauth.c @@ -229,6 +229,12 @@ virAuthGetPasswordPath(const char *path, return NULL; } =20 + if (!auth->cb) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("Missing authentication callback")); + return NULL; + } + prompt =3D g_strdup_printf(_("Enter %1$s's password for %2$s"), userna= me, hostname); =20 if (!(cred =3D virAuthAskCredential(auth, prompt, false))) --=20 2.53.0