From nobody Sun Feb 8 13:53:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1574686868; cv=none; d=zohomail.com; s=zohoarc; b=lSZETn7pu9t9Di1CHSWINCdi5fu1dtoZbtZOBDWay1u9qfRKLPNLoe/cNERv/itLSjPVPbqITSIvgDEwqCFHtSDknkWGrvjvX5LIMBmKbMl+RGK0USDGZ1m/zO+3u5ULt8vUQiTUkWbNcoBhW+Dhy6Z3ss6WCymgDY7SqFGTcmU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574686868; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZQOZ5mH3y8vZ5wRujgOnRMJPrauKMohKhvTBo5Nqi9Y=; b=DlLbGH0Ni5D/56eT01a/UI62AVKJ+fybs3VBTPmvRem+pv9xdpLIVMj5lcsnuOhl9B0sfSRaIoIx96oRCWcue2Bc8AK+UgELHJnplelp7uLUPxZi8s3cSHfLWEf6EMpowzraabB47ruOT6MlYZzzSr+nta7xSNEeB+LJXXArQ0k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1574686868265575.6528395062838; Mon, 25 Nov 2019 05:01:08 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-54-KKYlGYBkNZ2lMW8VUUHRoA-1; Mon, 25 Nov 2019 07:54:17 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EFC9C10950EB; Mon, 25 Nov 2019 12:54:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C69CF19C6A; Mon, 25 Nov 2019 12:54:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7FDDB18089CE; Mon, 25 Nov 2019 12:54:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xAPCrwLf016628 for ; Mon, 25 Nov 2019 07:53:58 -0500 Received: by smtp.corp.redhat.com (Postfix) id B66F8600CA; Mon, 25 Nov 2019 12:53:58 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3EF27600C8 for ; Mon, 25 Nov 2019 12:53:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574686867; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ZQOZ5mH3y8vZ5wRujgOnRMJPrauKMohKhvTBo5Nqi9Y=; b=c8n6qKbbfinO4jlHT4owTvge9vGCx2MWH76onLc9XhcIC0eQcjgl2GsNuZep+U8eRVLd0z WmNFJEM8oOyUTVlO1zUTFmVUeVapObHPeHVUHB6VF9A6zKARN/1oj8aZa5YnoC8i3r62r8 mtdzxohZkfPglRy6WDLPF1tv/pEMfK8= From: Peter Krempa To: libvir-list@redhat.com Date: Mon, 25 Nov 2019 13:53:46 +0100 Message-Id: <6960213af724f6cf19f8075cc7faf0e2649c1926.1574686331.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/9] qemu: process: Make it obvious that virDomainDefPostParse is called with NULL opaque X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: KKYlGYBkNZ2lMW8VUUHRoA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit c90fb5a828a added explicit use of the private copy of the qemu capabilities to various places. The change to qemuProcessInit was bogus though as at the point where we re-initiate the post parse callbacks priv->qemuCaps is still NULL as we clear it after shutdown of the VM and don't initiate it until a later point. Using the value from priv->qemuCaps might mislead readers of the code into thinking that something useful is being passed at that point so go with an explicit NULL instead. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 161b3910e5..1b88c471f4 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5531,7 +5531,8 @@ qemuProcessInit(virQEMUDriverPtr driver, if (vm->def->postParseFailed) { VIR_DEBUG("re-running the post parse callback"); - if (virDomainDefPostParse(vm->def, caps, 0, driver->xmlopt, priv->= qemuCaps) < 0) + /* we don't have the private copy of qemuCaps at this point */ + if (virDomainDefPostParse(vm->def, caps, 0, driver->xmlopt, NULL) = < 0) goto cleanup; } --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list