From nobody Mon Feb 9 12:29:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1677853745; cv=none; d=zohomail.com; s=zohoarc; b=brRGOr6CNEPMdO+GdE6TlhG0Dve/fI+hVLYEOqrxPm+L23ZoRNt72QXpWMR3j/JtILTG0E9kH+dJa59pXKxlA5HO56Cc4tRUEArpkEk3pQztYtDs3BPmGQHgKg17j1ixgGLzljUTP4sqrHIHqnpwfDZimQa5FD2zvZv2rMSdEXY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677853745; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DsfDcQ/6VksQ5L9HwQ4IrGLLXcDE+TQQiFHeTHD6Z+w=; b=TMOAlTs6LgFE0+cz4BW+cMw+2Kh2LxjiZi+f0Fmw+U9mCSJ3Aujkv1Cp+8ihMVIX9pTlz4UjcwSDGYXh3ArW76Rb+ooslGfGmUJTfHMpuJQCr2rLmzuZf7xWWnZFNGd0ZHrm/Eo2wEwIYR5imbAEgLOuAYRqoL1HmISq8ETMyaM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1677853745872896.4279754734572; Fri, 3 Mar 2023 06:29:05 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-d6asiD25OJe9mJRbDOXPJA-1; Fri, 03 Mar 2023 09:28:24 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 249B4100F91C; Fri, 3 Mar 2023 14:28:22 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB6AF404BECA; Fri, 3 Mar 2023 14:28:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 954DC1949759; Fri, 3 Mar 2023 14:28:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 03CF41943BC6 for ; Fri, 3 Mar 2023 14:28:12 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E98AF4011AC8; Fri, 3 Mar 2023 14:28:11 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 707274097544 for ; Fri, 3 Mar 2023 14:28:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677853744; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DsfDcQ/6VksQ5L9HwQ4IrGLLXcDE+TQQiFHeTHD6Z+w=; b=bZZcI3fZCBhzLuQLBUMgaiIJCjyXSS4NPn45IZVvt+wstVOTpNIDulEF94/JmSlw6jeZtU HhSjgJUo1CuIXBRgua2QT9Qq0/Ubmq9AlQQ3HuL2FIJdBrHx6+XeX8DHhMhnkSdvFZqS9D F4L8YXiGOFcW5WRS1NNGPLjq2zu5Oc8= X-MC-Unique: d6asiD25OJe9mJRbDOXPJA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 04/31] qemuxml2argvtest: Fix serial-unix-missing-source case Date: Fri, 3 Mar 2023 15:27:38 +0100 Message-Id: <6947c93724e2790429d3ffb153c614112803d427.1677853487.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1677853746757100003 Content-Type: text/plain; charset="utf-8" Use x86_64 emulator and machine and remove the nocaps version of the test. Fixes: 80a37e96a95 Signed-off-by: Peter Krempa --- tests/qemuxml2argvdata/serial-unix-missing-source.err | 1 - .../serial-unix-missing-source.x86_64-latest.err | 2 +- tests/qemuxml2argvdata/serial-unix-missing-source.xml | 4 ++-- tests/qemuxml2argvtest.c | 1 - 4 files changed, 3 insertions(+), 5 deletions(-) delete mode 100644 tests/qemuxml2argvdata/serial-unix-missing-source.err diff --git a/tests/qemuxml2argvdata/serial-unix-missing-source.err b/tests/= qemuxml2argvdata/serial-unix-missing-source.err deleted file mode 100644 index bfbefc8cce..0000000000 --- a/tests/qemuxml2argvdata/serial-unix-missing-source.err +++ /dev/null @@ -1 +0,0 @@ -internal error: Missing source path attribute for char device diff --git a/tests/qemuxml2argvdata/serial-unix-missing-source.x86_64-lates= t.err b/tests/qemuxml2argvdata/serial-unix-missing-source.x86_64-latest.err index 86be3aead4..bfbefc8cce 100644 --- a/tests/qemuxml2argvdata/serial-unix-missing-source.x86_64-latest.err +++ b/tests/qemuxml2argvdata/serial-unix-missing-source.x86_64-latest.err @@ -1 +1 @@ -unsupported configuration: Emulator '/usr/bin/qemu-system-aarch64' does no= t support arch 'aarch64' +internal error: Missing source path attribute for char device diff --git a/tests/qemuxml2argvdata/serial-unix-missing-source.xml b/tests/= qemuxml2argvdata/serial-unix-missing-source.xml index 1e1221f12d..462f2b429e 100644 --- a/tests/qemuxml2argvdata/serial-unix-missing-source.xml +++ b/tests/qemuxml2argvdata/serial-unix-missing-source.xml @@ -4,10 +4,10 @@ 1048576 1 - hvm + hvm - /usr/bin/qemu-system-aarch64 + /usr/bin/qemu-system-x86_64 diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 5a33c336c8..fa60028cf0 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1551,7 +1551,6 @@ mymain(void) DO_TEST_CAPS_LATEST("serial-dev-chardev-iobase"); DO_TEST_CAPS_LATEST("serial-file-chardev"); DO_TEST_CAPS_LATEST("serial-unix-chardev"); - DO_TEST_PARSE_ERROR_NOCAPS("serial-unix-missing-source"); DO_TEST("serial-tcp-chardev", QEMU_CAPS_DEVICE_ISA_SERIAL); DO_TEST("serial-udp-chardev", --=20 2.39.2