From nobody Mon Feb 9 01:48:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1645026109; cv=none; d=zohomail.com; s=zohoarc; b=SGhIswCC4mOtv4hjLlpXMX5Sda0bb+auMqFRRS9SN/LITcNEm96aq6tpWS6nMltxTT41hWePbZta0LmCqIjWn4TZ1fT727DABYGUX62VAS2/LzTespCU/VsXCZeeDYPEB3eQKjuLKKJ+BtPWZGscD9QyoDL0OAPoTNcxT7do5nM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645026109; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jmkk/NvLjA53coi87wZcLn0tlzInrQKIfDYewHVUxkw=; b=g2lvLuOGbw4vy7dCnDNSRG2/pPjP5pSsaVHHbRmLg2ySQ4L2kyhdK61dg8ZB7J5aUwpojJBELccqKqscy/APnvssZ4Vk60cBTWBmkmohstOlrmJecGh46YSmNirqfe03qKr0gLHyvB9MH9fHoAFdpwm5c4mU4NT8AkcWyDIZ+Xg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1645026109660407.0354079060837; Wed, 16 Feb 2022 07:41:49 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-413-mJKeDpT9PoS95h1U87Zseg-1; Wed, 16 Feb 2022 10:41:39 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8CB8B2F44; Wed, 16 Feb 2022 15:41:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6AAB14699F; Wed, 16 Feb 2022 15:41:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3B7DD1802FE9; Wed, 16 Feb 2022 15:41:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21GFfUQg021214 for ; Wed, 16 Feb 2022 10:41:30 -0500 Received: by smtp.corp.redhat.com (Postfix) id A9E5874E8C; Wed, 16 Feb 2022 15:41:30 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.41]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CD1574EA0 for ; Wed, 16 Feb 2022 15:41:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645026108; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jmkk/NvLjA53coi87wZcLn0tlzInrQKIfDYewHVUxkw=; b=KbJph0weRCMiFoLPj6GzfesR+SFEzXShzqF+HmuT3XgAz/PqmDoDhSzSLz5cX8YbGuToWG 74CA8+pXjEA/6fp8JAEVujGe6N1vrolHT29bhFYMsnHeB2KESS5b0Q6JCUEKY9XPySYwHi pfHFxRr8dEZRCVB3jiqHYJJjyD5ARFQ= X-MC-Unique: mJKeDpT9PoS95h1U87Zseg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 7/8] virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_FD_PASSING Date: Wed, 16 Feb 2022 16:41:11 +0100 Message-Id: <692be366a27f3cee43443a36f17794536d2d429e.1645026017.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1645026110931100001 Content-Type: text/plain; charset="utf-8" The feature implies that fd passing works with RPC. Non-remote impls thus should always report support. Signed-off-by: Peter Krempa --- src/driver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/driver.c b/src/driver.c index 54b4ad5b43..758ee3e320 100644 --- a/src/driver.c +++ b/src/driver.c @@ -360,10 +360,14 @@ virDriverFeatureIsGlobal(virDrvFeature feat, /* Feature flag exposes that accidental switching of order of arguments * in RPC was fixed. All implementations need to advertise this featur= e */ case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: + /* The remote driver intercepts and always reports the feature since i= t was + * introduced. This means that all driver implementations should adver= tise + * it too as it works natively without RPC. Always enabling this will = also + * prevent regressions when a driver is used in embedded mode */ + case VIR_DRV_FEATURE_FD_PASSING: *supported =3D 1; return true; - case VIR_DRV_FEATURE_FD_PASSING: case VIR_DRV_FEATURE_MIGRATION_V2: case VIR_DRV_FEATURE_MIGRATION_V3: case VIR_DRV_FEATURE_MIGRATION_P2P: --=20 2.35.1