From nobody Thu Sep 19 01:13:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1716801596477793.6389491754722; Mon, 27 May 2024 02:19:56 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D8DC11B12; Mon, 27 May 2024 05:19:54 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id A9080191B; Mon, 27 May 2024 05:19:09 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 40E36191C; Mon, 27 May 2024 05:19:07 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id CDC111919 for ; Mon, 27 May 2024 05:19:06 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-vkAyJ1_ANOmqVatisCVP1Q-1; Mon, 27 May 2024 05:19:04 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2AA163C025BF for ; Mon, 27 May 2024 09:19:04 +0000 (UTC) Received: from maggie.brq.redhat.com (unknown [10.43.3.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB17740005B for ; Mon, 27 May 2024 09:19:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716801546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=34mI4s05n1XL7GkSWZt0YUfIgbTeDaVByLveudukf2U=; b=CzrGmGdnX14g62bf6cQ5Cp7LYD789G+Wat1WlSD+GrHf3fQzUbxkkYqnxMqz2mtGgcYY1W lOoRgBbwBpjIeieYL0dEDfDZE9jG5LpSt0LRcFjLFoacJrGXXCaDlTcXC8sUfxhmNMIpzM +/PjohN0peaYupW+ABzgx61OmUNi/2s= X-MC-Unique: vkAyJ1_ANOmqVatisCVP1Q-1 From: Michal Privoznik To: devel@lists.libvirt.org Subject: [PATCH 1/6] kbase: Use virt-admin daemon-timeout correctly Date: Mon, 27 May 2024 11:18:49 +0200 Message-ID: <691a9d2bb393688fc6e149b1eb1889ef1bfa6eda.1716801414.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Z6WAOKHIVIGFQJQBUVT33B5J5XT2L3SJ X-Message-ID-Hash: Z6WAOKHIVIGFQJQBUVT33B5J5XT2L3SJ X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1716801598383100001 Content-Type: text/plain; charset="utf-8"; x-default="true" In a few examples we recommend disabling daemon timeout when fetching debug logs. While it makes sense the actual syntax used results in an error: # virt-admin daemon-timeout 0 error: unexpected data '0' This is because --timeout is required. Update examples to include it. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- docs/kbase/debuglogs.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/kbase/debuglogs.rst b/docs/kbase/debuglogs.rst index f08132d099..dff2cfd144 100644 --- a/docs/kbase/debuglogs.rst +++ b/docs/kbase/debuglogs.rst @@ -25,7 +25,7 @@ the system clears this setting:: =20 # virt-admin -c virtqemud:///system daemon-log-outputs "3:journald 1:fi= le:/var/log/libvirt/libvirtd.log" # virt-admin -c virtqemud:///system daemon-log-filters "3:remote 4:even= t 3:util.json 3:util.object 3:util.dbus 3:util.netlink 3:node_device 3:rpc = 3:access 1:*" - # virt-admin -c virtqemud:///system daemon-timeout 0 + # virt-admin -c virtqemud:///system daemon-timeout --timeout 0 =20 The last command disabling timeout of the daemon is available since ``libvirt-8.6.0``. With older versions make sure to reproduce the issue wi= thin @@ -224,7 +224,7 @@ is re-started with another command. =20 To prevent auto-shutdown of the daemon you can use the following command:: =20 - virt-admin daemon-timeout 0 + virt-admin daemon-timeout --timeout 0 =20 The above is introduced in libvirt-8.6.0. =20 --=20 2.44.1