From nobody Tue Dec 16 17:13:41 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1738690028835169.83956964106937; Tue, 4 Feb 2025 09:27:08 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 007D31E82; Tue, 4 Feb 2025 12:27:08 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id DAED41DCB; Tue, 4 Feb 2025 12:25:45 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 463751E0B; Tue, 4 Feb 2025 12:25:41 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9999D1E0E for ; Tue, 4 Feb 2025 12:25:33 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-q1wrqjm1MIKndh1KdpFVZw-1; Tue, 04 Feb 2025 12:25:32 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0F4DF1801F16 for ; Tue, 4 Feb 2025 17:25:31 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.3]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3E93C18008C0 for ; Tue, 4 Feb 2025 17:25:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738689933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sGrPSRSsCfErcGXKSoXVSq47bZkt5pgPwaazU8Ho4vA=; b=MznYcdDImp/qkP9gCwtrU+xE1n+R7DZbBgZlf5T5jxHuvM/ThZLyHg8WZfYZctXHOtke2C xan4gX1Cai/JPgsoE23rDcEXTPe8KR9q+oOuie2Nm9eBq15E5hH/Vl6QCCQFGJpSmpUw4V Pj5YWfwGccMrS55rSrXEnP7rEjpm974= X-MC-Unique: q1wrqjm1MIKndh1KdpFVZw-1 X-Mimecast-MFC-AGG-ID: q1wrqjm1MIKndh1KdpFVZw From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 4/5] qemu: blockjob: Remove persistent reservations manager when dropping disk images Date: Tue, 4 Feb 2025 18:25:22 +0100 Message-ID: <690b547a0c88d6dd307ad86cb56e869f44e8b50c.1738689879.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XFmqRmQiDJ12nx1crwbZ_MwOjTuhqjRDYpmcNO5NtfU_1738689931 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7G3TLI4JIZ5N22JQGEB2MFM77JAQGPDU X-Message-ID-Hash: 7G3TLI4JIZ5N22JQGEB2MFM77JAQGPDU X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1738690031087019000 Content-Type: text/plain; charset="utf-8" Check if the persistent reservations manager daemon is still needed after a disk (sub)-chain was dropped after a blockjob. Signed-off-by: Peter Krempa --- src/qemu/qemu_blockjob.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c index 4e77543fa8..3aef1ec285 100644 --- a/src/qemu/qemu_blockjob.c +++ b/src/qemu/qemu_blockjob.c @@ -28,6 +28,7 @@ #include "qemu_domain.h" #include "qemu_alias.h" #include "qemu_backup.h" +#include "qemu_hotplug.h" #include "conf/domain_conf.h" #include "conf/domain_event.h" @@ -707,6 +708,8 @@ qemuBlockJobEventProcessConcludedRemoveChain(virQEMUDri= ver *driver, qemuDomainObjExitMonitor(vm); qemuDomainStorageSourceChainAccessRevoke(driver, vm, chain); + + ignore_value(qemuHotplugRemoveManagedPR(vm, asyncJob)); } --=20 2.48.1