From nobody Wed Oct 22 12:31:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1759928323; cv=none; d=zohomail.com; s=zohoarc; b=huppZR5ST5QCgsy+TprhJ26elfK7V2ZV1NZuJAvbFEi4yRDmoDmcrEarJGGdUQWTBTnQahvlcVnIxutxvzVKlNvZqXifRL+GEifSbrxVw1uz91hDybt7J4mY2gthneiKzC+LPAa0MXboIs3b5dhnVLvYY1JCYAvHsChhtF5a5TA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759928323; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=OPUdCYtLtX8AntIfwZ8bpwCy/SjQ6dY6dwS1dkrAkmM=; b=BTcQhIGDZzHpKGV7BdsgSyN3ZiELTaXOv1Si7VHNC2YxtsoVS5FbVRJkeV34WcPUoCk8uzbBz5ewaCRXUmjveIF+ngXKLMvpIFSbevTgjJqrmfnbj3T6T2ojUIyvCV8tgft+Kg/EhcGWqnDWh5RcPVFP0hvcmfgbxhOQIB5vj/o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 175992832345768.40786093280315; Wed, 8 Oct 2025 05:58:43 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 987463F303; Wed, 8 Oct 2025 08:58:42 -0400 (EDT) Received: from [172.19.199.17] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 1142644352; Wed, 8 Oct 2025 08:57:48 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DA0F541B43; Wed, 8 Oct 2025 08:54:11 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0F25B41B30 for ; Wed, 8 Oct 2025 08:54:11 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-dbWX06TrNm-CmWOOv_FfwA-1; Wed, 08 Oct 2025 08:54:09 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 756F21955E94 for ; Wed, 8 Oct 2025 12:54:08 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C078B19560B8 for ; Wed, 8 Oct 2025 12:54:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759928050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OPUdCYtLtX8AntIfwZ8bpwCy/SjQ6dY6dwS1dkrAkmM=; b=Y9C0a/w9lEAZmaZ5pGVU+tYJMVO8T1VTZ6mu47l38nxELzSQFLMnZh0b70YAtzaqV9rkqr czqZ5J4fHAAgJcmaRzq3SyKRvLae77RBydYOuMuoCDdJI3mROqtg/IcF29xavKRcCgsfMV eVQAcDaLaTuzVKOapNaXLyuy6ALqODs= X-MC-Unique: dbWX06TrNm-CmWOOv_FfwA-1 X-Mimecast-MFC-AGG-ID: dbWX06TrNm-CmWOOv_FfwA_1759928048 To: devel@lists.libvirt.org Subject: [PATCH v2 02/29] src: Drop needless typecast to virDomainTimerNameType Date: Wed, 8 Oct 2025 14:53:34 +0200 Message-ID: <68d1642d4ae9a925cecb7e0540173ff4a853c335.1759927755.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _GFQdI2Ck8X7yyZ4DU1INd-owwfTjOMF8UGGw6tQ1v0_1759928048 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: PQXM5DZZADTDKXFDKLFBK5BLTJDDH5AU X-Message-ID-Hash: PQXM5DZZADTDKXFDKLFBK5BLTJDDH5AU X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1759928326963116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik This was missed in v8.10.0-rc1~229 which switched the 'name' member of _virDomainTimerDef struct from int to virDomainTimerNameType. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/libxl/libxl_conf.c | 2 +- src/libxl/xen_common.c | 2 +- src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_controller.c | 2 +- src/qemu/qemu_command.c | 6 +++--- src/qemu/qemu_validate.c | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 9d8301169b..0cbc09b6b0 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -397,7 +397,7 @@ libxlMakeDomBuildInfo(virDomainDef *def, } =20 for (i =3D 0; i < clock.ntimers; i++) { - switch ((virDomainTimerNameType) clock.timers[i]->name) { + switch (clock.timers[i]->name) { case VIR_DOMAIN_TIMER_NAME_TSC: switch (clock.timers[i]->mode) { case VIR_DOMAIN_TIMER_MODE_NATIVE: diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index a050f0ab6e..666c6cae20 100644 --- a/src/libxl/xen_common.c +++ b/src/libxl/xen_common.c @@ -2093,7 +2093,7 @@ xenFormatHypervisorFeatures(virConf *conf, virDomainD= ef *def) } =20 for (i =3D 0; i < def->clock.ntimers; i++) { - switch ((virDomainTimerNameType)def->clock.timers[i]->name) { + switch (def->clock.timers[i]->name) { case VIR_DOMAIN_TIMER_NAME_TSC: switch (def->clock.timers[i]->mode) { case VIR_DOMAIN_TIMER_MODE_NATIVE: diff --git a/src/lxc/lxc_cgroup.c b/src/lxc/lxc_cgroup.c index f566a5468e..1c637be38b 100644 --- a/src/lxc/lxc_cgroup.c +++ b/src/lxc/lxc_cgroup.c @@ -335,7 +335,7 @@ static int virLXCCgroupSetupDeviceACL(virDomainDef *def, if (timer->present =3D=3D VIR_TRISTATE_BOOL_NO) continue; =20 - switch ((virDomainTimerNameType)timer->name) { + switch (timer->name) { case VIR_DOMAIN_TIMER_NAME_PLATFORM: case VIR_DOMAIN_TIMER_NAME_TSC: case VIR_DOMAIN_TIMER_NAME_KVMCLOCK: diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index fb7f8e0bc2..3f4c8efdcf 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -1502,7 +1502,7 @@ virLXCControllerSetupTimers(virLXCController *ctrl) if (timer->present =3D=3D VIR_TRISTATE_BOOL_NO) continue; =20 - switch ((virDomainTimerNameType)timer->name) { + switch (timer->name) { case VIR_DOMAIN_TIMER_NAME_PLATFORM: case VIR_DOMAIN_TIMER_NAME_TSC: case VIR_DOMAIN_TIMER_NAME_KVMCLOCK: diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 08e2a5147d..f7af92fe35 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6047,7 +6047,7 @@ qemuBuildClockCommandLine(virCommand *cmd, } =20 for (i =3D 0; i < def->clock.ntimers; i++) { - switch ((virDomainTimerNameType)def->clock.timers[i]->name) { + switch (def->clock.timers[i]->name) { case VIR_DOMAIN_TIMER_NAME_PLATFORM: /* qemuDomainDefValidateClockTimers will handle this * error condition */ @@ -6491,7 +6491,7 @@ qemuBuildCpuCommandLine(virCommand *cmd, for (i =3D 0; i < def->clock.ntimers; i++) { virDomainTimerDef *timer =3D def->clock.timers[i]; =20 - switch ((virDomainTimerNameType)timer->name) { + switch (timer->name) { case VIR_DOMAIN_TIMER_NAME_KVMCLOCK: if (timer->present !=3D VIR_TRISTATE_BOOL_ABSENT) { /* QEMU expects on/off -> virTristateSwitch. */ @@ -7200,7 +7200,7 @@ qemuBuildMachineCommandLine(virCommand *cmd, } =20 for (i =3D 0; i < def->clock.ntimers; i++) { - switch ((virDomainTimerNameType)def->clock.timers[i]->name) { + switch (def->clock.timers[i]->name) { case VIR_DOMAIN_TIMER_NAME_HPET: /* qemuBuildClockCommandLine handles the old-style config via = '-no-hpet' */ if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_HPET) && diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 7f3ffe8bd5..8dac5c76d0 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -477,7 +477,7 @@ qemuValidateDomainDefClockTimers(const virDomainDef *de= f, for (i =3D 0; i < def->clock.ntimers; i++) { virDomainTimerDef *timer =3D def->clock.timers[i]; =20 - switch ((virDomainTimerNameType)timer->name) { + switch (timer->name) { case VIR_DOMAIN_TIMER_NAME_PLATFORM: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("unsupported timer type (name) '%1$s'"), --=20 2.49.1