From nobody Tue Jan 21 07:41:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1736183605324573.452615781274; Mon, 6 Jan 2025 09:13:25 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 6557AA74; Mon, 6 Jan 2025 12:13:24 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 4C909CB3; Mon, 6 Jan 2025 12:12:36 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 62FA7A20; Mon, 6 Jan 2025 12:12:31 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D7768866 for ; Mon, 6 Jan 2025 12:12:30 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-163-9N_ZVLqlOOSgbqwfoEYf2w-1; Mon, 06 Jan 2025 12:12:28 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D1C701956069 for ; Mon, 6 Jan 2025 17:12:27 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.225.134]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 067A019560A2 for ; Mon, 6 Jan 2025 17:12:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736183550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PkiTXN50gsvphYD6mFpU+08yP8HilcMtTW5Ed+nHLaQ=; b=CPaHabgJ+msXJ13DCcczV+g035IhWbaVmNq2qmgMXKU66vECzDaSSTuefeOVbVg7Qa6/BX /uUtPfdAeYqAcJYI5LesqATSFXA1JbThTuhLXZMx92Q8dnDJaoKpBKmOyeWHz4ZcNbgpfi xU7VhsYKN1BU/62LeKiodcuVeXSNjDc= X-MC-Unique: 9N_ZVLqlOOSgbqwfoEYf2w-1 X-Mimecast-MFC-AGG-ID: 9N_ZVLqlOOSgbqwfoEYf2w From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH v2 2/2] conf: Adjust hyperv tlbflush formatting Date: Mon, 6 Jan 2025 18:09:55 +0100 Message-ID: <68cc02d518486fddce6d2e63cc5908ae8c27de62.1736183395.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2Nas4GK6L-19r2jrkIWSFTQCWecgLUTo1BV_5cXxZTQ_1736183547 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: P3MDN5W7Y6FLNMYPLNMPN7QU63X3YWB6 X-Message-ID-Hash: P3MDN5W7Y6FLNMYPLNMPN7QU63X3YWB6 X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1736183606526116600 Content-Type: text/plain; charset="utf-8" From: Martin Kletzander Commit 247357cc292a added support for direct and extended modes for tlbflush, but forgot to do the formatting as well. Signed-off-by: Martin Kletzander Signed-off-by: J=C3=A1n Tomko --- src/conf/domain_conf.c | 11 ++++++++++- tests/qemuxmlconfdata/hyperv.x86_64-latest.xml | 5 ++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ba1b3a7398..af88d0bcfd 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -27974,7 +27974,6 @@ virDomainDefFormatFeatures(virBuffer *buf, case VIR_DOMAIN_HYPERV_RESET: case VIR_DOMAIN_HYPERV_FREQUENCIES: case VIR_DOMAIN_HYPERV_REENLIGHTENMENT: - case VIR_DOMAIN_HYPERV_TLBFLUSH: case VIR_DOMAIN_HYPERV_IPI: case VIR_DOMAIN_HYPERV_EVMCS: case VIR_DOMAIN_HYPERV_AVIC: @@ -28004,6 +28003,16 @@ virDomainDefFormatFeatures(virBuffer *buf, } break; =20 + case VIR_DOMAIN_HYPERV_TLBFLUSH: + if (def->hyperv_features[j] !=3D VIR_TRISTATE_SWITCH_O= N) + break; + + if (def->hyperv_tlbflush_direct =3D=3D VIR_TRISTATE_SW= ITCH_ON) + virBufferAddLit(&hypervChildBuf, "\n"); + if (def->hyperv_tlbflush_extended =3D=3D VIR_TRISTATE_= SWITCH_ON) + virBufferAddLit(&hypervChildBuf, "\n"); + break; + case VIR_DOMAIN_HYPERV_LAST: break; } diff --git a/tests/qemuxmlconfdata/hyperv.x86_64-latest.xml b/tests/qemuxml= confdata/hyperv.x86_64-latest.xml index 36d9161fa8..49537188af 100644 --- a/tests/qemuxmlconfdata/hyperv.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/hyperv.x86_64-latest.xml @@ -22,7 +22,10 @@ - + + + + --=20 2.47.0