[PATCH] domainbackupxml2xml: Add test case with unix socket server for pull mode backup

Peter Krempa posted 1 patch 1 month, 2 weeks ago
.../backup-pull-unix.xml                      | 22 ++++++++++++++++++
.../backup-pull-unix.xml                      | 23 +++++++++++++++++++
tests/genericxml2xmltest.c                    |  1 +
3 files changed, 46 insertions(+)
create mode 100644 tests/domainbackupxml2xmlin/backup-pull-unix.xml
create mode 100644 tests/domainbackupxml2xmlout/backup-pull-unix.xml
[PATCH] domainbackupxml2xml: Add test case with unix socket server for pull mode backup
Posted by Peter Krempa 1 month, 2 weeks ago
While we show the example in the docs we don't have an example XML for
exrecrcising the parser/formatter and schema.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 .../backup-pull-unix.xml                      | 22 ++++++++++++++++++
 .../backup-pull-unix.xml                      | 23 +++++++++++++++++++
 tests/genericxml2xmltest.c                    |  1 +
 3 files changed, 46 insertions(+)
 create mode 100644 tests/domainbackupxml2xmlin/backup-pull-unix.xml
 create mode 100644 tests/domainbackupxml2xmlout/backup-pull-unix.xml

diff --git a/tests/domainbackupxml2xmlin/backup-pull-unix.xml b/tests/domainbackupxml2xmlin/backup-pull-unix.xml
new file mode 100644
index 0000000000..cde9ceafc9
--- /dev/null
+++ b/tests/domainbackupxml2xmlin/backup-pull-unix.xml
@@ -0,0 +1,22 @@
+<domainbackup mode='pull'>
+  <incremental>1525889631</incremental>
+  <server transport='unix' socket='/path/to/server'/>
+  <disks>
+    <disk name='vda' type='file'>
+      <scratch file='/path/to/file'/>
+    </disk>
+    <disk name='hda' backup='no'/>
+    <disk name='vdc' type='file' backupmode='full'>
+      <scratch file='/path/to/file'/>
+    </disk>
+    <disk name='vdd' type='file' backupmode='incremental'>
+      <scratch file='/path/to/file'/>
+    </disk>
+    <disk name='vde' type='file' backupmode='incremental' incremental='blah'>
+      <scratch file='/path/to/file'/>
+    </disk>
+    <disk name='vdf' type='file' incremental='bleh'>
+      <scratch file='/path/to/file'/>
+    </disk>
+  </disks>
+</domainbackup>
diff --git a/tests/domainbackupxml2xmlout/backup-pull-unix.xml b/tests/domainbackupxml2xmlout/backup-pull-unix.xml
new file mode 100644
index 0000000000..811edfdf39
--- /dev/null
+++ b/tests/domainbackupxml2xmlout/backup-pull-unix.xml
@@ -0,0 +1,23 @@
+<domainbackup mode='pull'>
+  <incremental>1525889631</incremental>
+  <server transport='unix' socket='/path/to/server'/>
+  <disks>
+    <disk name='vda' backup='yes' type='file' backupmode='incremental' incremental='1525889631'>
+      <scratch file='/path/to/file'/>
+    </disk>
+    <disk name='hda' backup='no'/>
+    <disk name='vdc' backup='yes' type='file' backupmode='full'>
+      <scratch file='/path/to/file'/>
+    </disk>
+    <disk name='vdd' backup='yes' type='file' backupmode='incremental' incremental='1525889631'>
+      <scratch file='/path/to/file'/>
+    </disk>
+    <disk name='vde' backup='yes' type='file' backupmode='incremental' incremental='blah'>
+      <scratch file='/path/to/file'/>
+    </disk>
+    <disk name='vdf' backup='yes' type='file' backupmode='incremental' incremental='bleh'>
+      <scratch file='/path/to/file'/>
+    </disk>
+    <disk name='vdextradisk' backup='no'/>
+  </disks>
+</domainbackup>
diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c
index 61613d21f9..b46b9515c3 100644
--- a/tests/genericxml2xmltest.c
+++ b/tests/genericxml2xmltest.c
@@ -244,6 +244,7 @@ mymain(void)

     DO_TEST_BACKUP("empty");
     DO_TEST_BACKUP("backup-pull");
+    DO_TEST_BACKUP("backup-pull-unix");
     DO_TEST_BACKUP("backup-pull-seclabel");
     DO_TEST_BACKUP("backup-pull-encrypted");
     DO_TEST_BACKUP("backup-push");
-- 
2.48.1
Re: [PATCH] domainbackupxml2xml: Add test case with unix socket server for pull mode backup
Posted by Ján Tomko 1 month, 2 weeks ago
On a Wednesday in 2025, Peter Krempa wrote:
>While we show the example in the docs we don't have an example XML for
>exrecrcising the parser/formatter and schema.
>

exercising

>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> .../backup-pull-unix.xml                      | 22 ++++++++++++++++++
> .../backup-pull-unix.xml                      | 23 +++++++++++++++++++
> tests/genericxml2xmltest.c                    |  1 +
> 3 files changed, 46 insertions(+)
> create mode 100644 tests/domainbackupxml2xmlin/backup-pull-unix.xml
> create mode 100644 tests/domainbackupxml2xmlout/backup-pull-unix.xml
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano