From nobody Sun Feb 8 21:48:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612285111; cv=none; d=zohomail.com; s=zohoarc; b=ZxTq0rkA8N2FhYGujmb08iJZVqb6fPbaAeWlrHxeL9PKvaUmIVsF3TEN+dLfOlNUoRXepkNFuffQfwhgfOwHhaFiinVPtGJFrGfBEID6HqiqISE/aMkN1g7Q6RP7cbjE7y1O1kQbELvPuv3pn4bdSKaE40sxZEKpIvoh1tDGeJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612285111; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=D4KBq2PZbSqrzG8ICyTAy9ebmtfMTV6icX1rV40K3B0=; b=X+VOcB28lkxwuZfNakWKHjF7C46OrLXeo4EBDMjoPhs5VjD98eUXj11MN20QVMMdqwUXHdl5xAYq1Jcgg0rrPhUKOA2/Q+Q/YMVkg6rrsrReEaNDFFqYb4GPB7Ql4P5ix+H86nm0NE5Fiu8L24xSpurZH7ibF1MCMoluBLjZTv8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1612285111738804.016865918892; Tue, 2 Feb 2021 08:58:31 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-3sDA-8yzP2CKROEimdVrXQ-1; Tue, 02 Feb 2021 11:57:12 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2EA1F107ACF5; Tue, 2 Feb 2021 16:57:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0AF405C237; Tue, 2 Feb 2021 16:57:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C54085004B; Tue, 2 Feb 2021 16:57:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 112Gv3nr015199 for ; Tue, 2 Feb 2021 11:57:03 -0500 Received: by smtp.corp.redhat.com (Postfix) id 024056EF45; Tue, 2 Feb 2021 16:57:03 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 09F7F6E510 for ; Tue, 2 Feb 2021 16:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612285110; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=D4KBq2PZbSqrzG8ICyTAy9ebmtfMTV6icX1rV40K3B0=; b=NibQBBiMBSHSHv5aVyzzI/VlPTNi65YEkpH8Msyqt+nSDvs3Nfb+3FwYWpnXFP/T+9lfT7 d4YyI2t6jGo+KX2oPK3FYaoPGq027OBH0/KaxKJgpMjyiUQkSX0nf/FXE6F0LWtAjjeouc 8rtfm3Ek8YztsUckXD1joB2IhoQjsNY= X-MC-Unique: 3sDA-8yzP2CKROEimdVrXQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH v2 16/27] storageBackendCreateQemuImgSecretPath: Use virSecureErase instead of VIR_DISPOSE_N Date: Tue, 2 Feb 2021 17:55:53 +0100 Message-Id: <676b46a85177f0b986afcdf201239a6f2a3e2cb7.1612284661.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Clear out the value using virSecureErase and free it with g_free so that VIR_DISPOSE_N can be phased out. Signed-off-by: Peter Krempa Reviewed-by: Daniel P. Berrang=C3=A9 --- src/storage/storage_util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 3d8de16341..b5adb05826 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -74,6 +74,7 @@ #include "virxml.h" #include "virfdstream.h" #include "virutil.h" +#include "virsecureerase.h" #define VIR_FROM_THIS VIR_FROM_STORAGE @@ -1314,7 +1315,8 @@ storageBackendCreateQemuImgSecretPath(virStoragePoolO= bjPtr pool, cleanup: virObjectUnref(conn); - VIR_DISPOSE_N(secret, secretlen); + virSecureErase(secret, secretlen); + g_free(secret); return secretPath; --=20 2.29.2