From nobody Fri May 3 15:05:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1643122173; cv=none; d=zohomail.com; s=zohoarc; b=kxPEuYmaRVaBXxF6Qy+AK4M9pyJMWBuRTgbpR81/thODfo+Y9xxjQARjpreoqyRDlGEr016URLpxIYpTm1EtMC0hnBNf5WhzSHNs+4a2JX/mrOrtECbu4nCYAhCtIePfScy3VYzDi0lZuYhtYwEdgU14Nj9hU5TtMJwWuGoAgDI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643122173; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=kBarjHPr/9lZC7wYnuof3ep7PU2nDXSOWpdMZz8+LmM=; b=JSusKrssCurjAA3ipzpga4xs3FXkTh1HE42n+/NHd31Z5jb/mqmh7gB/dWAtQR2s1yc3ZZSMntkm2I6Mt6O2z9o+7rXMTAXhY9+6Y25P+/gHjEHBlG3/OGu6mFlbDRDeW6g+Q2sqSuQzrPMCGhmV63yK+x1ONRHBFSveLkd5ITQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1643122173556891.4629954157689; Tue, 25 Jan 2022 06:49:33 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-561-BAS4T0AUPQqtz4TqRDMGIQ-1; Tue, 25 Jan 2022 09:49:28 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 48C7983DD46; Tue, 25 Jan 2022 14:49:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E06016E200; Tue, 25 Jan 2022 14:49:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 217A94BB7B; Tue, 25 Jan 2022 14:49:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20PEnHPo026968 for ; Tue, 25 Jan 2022 09:49:17 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8E38C7D3E3; Tue, 25 Jan 2022 14:49:17 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id DACA37D3E2 for ; Tue, 25 Jan 2022 14:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643122172; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=kBarjHPr/9lZC7wYnuof3ep7PU2nDXSOWpdMZz8+LmM=; b=W9Ey55BIBZeGKOW4iEDEH5VK4ixDikBHR+kb1QeEdEzlqtuXM9UDWIQFebYi8frxbJHWmP 357dP8fFvBVpXwBPZPKlgBRGShcgMdvbS7ZhBjqGaZzEI6jWuir+msHu/eZs68dWGwoAiJ 51cBKfq7JHGuV4evDEOBhuVpU+CrMhA= X-MC-Unique: BAS4T0AUPQqtz4TqRDMGIQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH] conf: network: Allow hostnames to start with a number Date: Tue, 25 Jan 2022 15:49:15 +0100 Message-Id: <673b74be5fda928da5e9f3c2cfbf6c1cb1eda0c6.1643122118.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1643122176144100001 From: Nicolas L=C3=A9cureuil RFC952 mandated that hostnames would start with an alpha character. This requirement was later relaxed by RFC1123 which allowed hostnames to start with a number as well. https://datatracker.ietf.org/doc/html/rfc952 https://datatracker.ietf.org/doc/html/rfc1123#page-13 Signed-off-by: Nicolas L=C3=A9cureuil Reviewed-by: Peter Krempa --- Pushed after review of a trivial merge request. src/conf/network_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 10d3330fdf..c769bbaeb5 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -548,7 +548,7 @@ virNetworkDHCPHostDefParseXML(const char *networkName, } name =3D virXMLPropString(node, "name"); - if (name && (!g_ascii_isalpha(name[0]))) { + if (name && !(g_ascii_isalpha(name[0]) || g_ascii_isdigit(name[0]))) { virReportError(VIR_ERR_XML_ERROR, _("Cannot use host name '%s' in network '%s'"), name, networkName); --=20 2.34.1