From nobody Mon Feb 9 01:17:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1637839017; cv=none; d=zohomail.com; s=zohoarc; b=Iz3TAByam1NK5Zl100fRmwlnAAtC62bXlo7ZrzANdlJcUeMC5m09wQbz/lBk1h4nAkKSeaPuLSmhz/cvpjky8HDjpAHP4rOK3aQdRxvMzLmq4Ho5MVW/uaBKXk2lCtRIXi57kLUP5r3SJOvt02l+cg51geOmw0kozhR9JhOnN5A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637839017; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AhiTcdQoHlKXHKoXW4I6qCns0TBOok5XqQmKcHaDD8M=; b=IlmbBn2ZqAam1O19N6Sq/g+NwfK2sluvZuBV7ylgs/jrWqwhSnRyNWuJH/uD368sz2Agna2EySMtRkMRLjcH+1hqOQTcq7SvtAt/MQs3lEO++gGHUHmH+bDevx+z3Gb9ak4GzG/zlfepUkoHvrQlHli9gzADz9A7N9MGoDT46Kk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1637839017652377.03952743386446; Thu, 25 Nov 2021 03:16:57 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-353-X016PrH6O76qx93jTJQZ1Q-1; Thu, 25 Nov 2021 06:16:53 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 20384101AFCC; Thu, 25 Nov 2021 11:16:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0182557BE; Thu, 25 Nov 2021 11:16:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CA6D61806D2E; Thu, 25 Nov 2021 11:16:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1APBGkO1022941 for ; Thu, 25 Nov 2021 06:16:46 -0500 Received: by smtp.corp.redhat.com (Postfix) id 755ED1042A90; Thu, 25 Nov 2021 11:16:46 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.194.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id E627E104B4E0 for ; Thu, 25 Nov 2021 11:16:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637839016; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=AhiTcdQoHlKXHKoXW4I6qCns0TBOok5XqQmKcHaDD8M=; b=ZmIQlZRg3lms9T4NbrNwH5SGbGPEKYoNytkEU0dMq29ei8JzcAmLjPb6cbgJygJVWHwkSp bRyMqVteS9zp2IGnANp7yB6gRHYs6TRokimUM5Hl7j1QRZ6NphWeU8EwxJ4/WNuliBwG6X YkIi9YMD9BnvBO5S17aOw09vVZIntLA= X-MC-Unique: X016PrH6O76qx93jTJQZ1Q-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 11/11] qemu_snapshot: create: drop redefine boolean Date: Thu, 25 Nov 2021 12:16:17 +0100 Message-Id: <66e886ed961650a1d4fb9553e9e6c10a3f3dc091.1637838934.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1637839018759100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina --- src/qemu/qemu_snapshot.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index c5f0a5afe8..2b4d8e801b 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -1840,7 +1840,6 @@ qemuSnapshotCreateXML(virDomainPtr domain, { virQEMUDriver *driver =3D domain->conn->privateData; virDomainSnapshotPtr snapshot =3D NULL; - bool redefine =3D flags & VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE; g_autoptr(virQEMUDriverConfig) cfg =3D virQEMUDriverGetConfig(driver); g_autoptr(virDomainSnapshotDef) def =3D NULL; =20 @@ -1887,7 +1886,7 @@ qemuSnapshotCreateXML(virDomainPtr domain, =20 qemuDomainObjSetAsyncJobMask(vm, QEMU_JOB_NONE); =20 - if (redefine) { + if (flags & VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE) { snapshot =3D qemuSnapshotRedefine(vm, domain, def, driver, cfg, fl= ags); } else { snapshot =3D qemuSnapshotCreate(vm, domain, def, driver, cfg, flag= s); --=20 2.31.1