From nobody Sat Feb 7 05:48:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1591868639; cv=none; d=zohomail.com; s=zohoarc; b=dT15CAWg2yuO/FkyVK88MRLjRaW+uPebc03Xx7IkEQeIh+iAfSdaUOk/yiT8x0hh8COp2Vm3OWywevUpZ2oyRDfFHz9tBgDhqEhKCTPqHg61USKe2qm3n4GqgNd/Z/MrYMpV7Uu4wXCB+2zYlIV0uo+o2YeXlYTsNdfAohOMbqg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591868639; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9jXQKlt9rUaxlbYw/vlN9cYxPAR1kbCbXl27cgY/hSs=; b=eU6sO3QR6qmmgNCsJvypio9cTaG2C+GmlDkaHnYQXaRIEJPfY8XM6M45GEPPIZ7cj90LT5O9VGDQM6wd0iGwZhl45f3ijjjQVFiBEB0wYdX3epQr1T6hVIFYEA9ICUd8LNfwhPeU10wMO4eGgvmB7xtApb3aoI/20ZZOjEBVgZ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1591868639363976.6508914540639; Thu, 11 Jun 2020 02:43:59 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-46-Ofi8XTN0Od6Biqzz70WPWw-1; Thu, 11 Jun 2020 05:43:55 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AABA51005513; Thu, 11 Jun 2020 09:43:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 54ECA5C3E7; Thu, 11 Jun 2020 09:43:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BA86CB34AC; Thu, 11 Jun 2020 09:43:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05B9hjD4030231 for ; Thu, 11 Jun 2020 05:43:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4E8C77C3B7; Thu, 11 Jun 2020 09:43:45 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.40.208.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1B0B78914 for ; Thu, 11 Jun 2020 09:43:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591868638; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9jXQKlt9rUaxlbYw/vlN9cYxPAR1kbCbXl27cgY/hSs=; b=Q/u1QaBtxRP8ZbLxpD8DMRHszRdtBwDoYeU56Ghj9uPKjXcNjhAnx+oQm4ELSkmWrdKr1a t3EmG0dwmzHpZBZrE+tQLwiLVRbInHMdbh2AJuoo2HHPHMZibXiHI27fiqu5e5cLTbri40 3PK/C6cHTBvpwY5gh1rnNjvKjFlf0vI= X-MC-Unique: Ofi8XTN0Od6Biqzz70WPWw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/7] libxlDomainMigrationDstPrepareDef: remove use of temporary variable Date: Thu, 11 Jun 2020 11:43:33 +0200 Message-Id: <6697c931c077bf650ac9bcd2f396bef5107c270e.1591868343.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We can free 'def->name' directly. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/libxl/libxl_migration.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index defdda5ed6..9d253346eb 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@ -449,7 +449,6 @@ libxlDomainMigrationDstPrepareDef(libxlDriverPrivatePtr= driver, { libxlDriverConfigPtr cfg =3D libxlDriverConfigGet(driver); virDomainDefPtr def; - char *name =3D NULL; if (!dom_xml) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", @@ -464,13 +463,12 @@ libxlDomainMigrationDstPrepareDef(libxlDriverPrivateP= tr driver, goto cleanup; if (dname) { - name =3D def->name; + VIR_FREE(def->name); def->name =3D g_strdup(dname); } cleanup: virObjectUnref(cfg); - VIR_FREE(name); return def; } --=20 2.26.2