From nobody Mon Feb 9 02:07:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633622313; cv=none; d=zohomail.com; s=zohoarc; b=hAldoXY3wPkE5rs6dMK1Zxq1zUe/ioofgJy8DNbT1APAqMWwWearBi+zgbqwsa/CQ0yAhB3T/0cDX3AhytJo4O3H96nqfbA6M0DFQv+fJ7iGTjQU3ij+djy/VwBVLeMyqlzv5ZbZTiBXC7LMt1wcwKHlxS5aE425PH4Lecn/4F0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633622313; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tPFJxp7w3vqv27UgXDS9nPm49+XAEcP0xSTvTgZf+Pk=; b=DwHhxyrgintTpB5d3B4kmGxsRkckR5NHALUU0GVsLhSfnNnBtRYhRFzf8vOzIOIeMVxcS78KZFtGduWLklm6e5frEbZocKvjvlhFBSE9iYtJ/SaAKjtMijp7r9jUJR01CTjzGTWBWM8d+nBJgBlbguqdhdKwBaa4T15+2F3cGd4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1633622313834672.8417402804505; Thu, 7 Oct 2021 08:58:33 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-464-UsH93Bn0OxqTSvXf5NGo8A-1; Thu, 07 Oct 2021 11:58:30 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2076410338D0; Thu, 7 Oct 2021 15:42:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 006E76F53F; Thu, 7 Oct 2021 15:42:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BA0AC1800B8B; Thu, 7 Oct 2021 15:42:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 197FIk28023602 for ; Thu, 7 Oct 2021 11:18:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 147E35F514; Thu, 7 Oct 2021 15:18:46 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6EBC25F4F1 for ; Thu, 7 Oct 2021 15:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633622312; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=tPFJxp7w3vqv27UgXDS9nPm49+XAEcP0xSTvTgZf+Pk=; b=XCsImRtIOGzCrwYBSOxItjaxAtJ7aG5RoMaWcT5rWsHZwTrHBTO3qU8bkHLV3M3pTUDfLr Co57Tu8JFAYDKePrvRpDzzrabmOli7mICrRqXEFJvjsFpzwzGcnI5Ue8X3a65mnhg7iNgJ A6T+AEGRaaSPd6naUMJVReYjvMWDF9c= X-MC-Unique: UsH93Bn0OxqTSvXf5NGo8A-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 012/103] virQEMUBuildNetdevCommandlineFromJSON: Remove unused formatter Date: Thu, 7 Oct 2021 17:17:00 +0200 Message-Id: <6651ba59253c5cf935474980661183d9934b07ff.1633619630.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633622314335100001 Content-Type: text/plain; charset="utf-8" Now that everything was replaced by the new code we can remove this function. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 - src/util/virqemu.c | 30 ------------------------------ src/util/virqemu.h | 4 ---- 3 files changed, 35 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index a58f2e4552..cffd3d638c 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -3120,7 +3120,6 @@ virQEMUBuildCommandLineJSONArrayBitmap; virQEMUBuildCommandLineJSONArrayNumbered; virQEMUBuildCommandLineJSONArrayObjectsStr; virQEMUBuildDriveCommandlineFromJSON; -virQEMUBuildNetdevCommandlineFromJSON; # util/virrandom.h diff --git a/src/util/virqemu.c b/src/util/virqemu.c index ff6e13b963..8119643431 100644 --- a/src/util/virqemu.c +++ b/src/util/virqemu.c @@ -283,36 +283,6 @@ virQEMUBuildCommandLineJSON(virJSONValue *value, } -/** - * virQEMUBuildNetdevCommandlineFromJSON: - * @props: JSON properties describing a netdev - * @rawjson: don't transform to commandline args, but just stringify json - * - * Converts @props into arguments for -netdev including all the quirks and - * differences between the monitor and command line syntax. - * - * @rawjson is meant for testing of the schema in the xml2argvtest - */ -char * -virQEMUBuildNetdevCommandlineFromJSON(virJSONValue *props, - bool rawjson) -{ - const char *type =3D virJSONValueObjectGetString(props, "type"); - g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; - - if (rawjson) - return virJSONValueToString(props, false); - - virBufferAsprintf(&buf, "%s,", type); - - if (virQEMUBuildCommandLineJSON(props, &buf, "type", - virQEMUBuildCommandLineJSONArrayObject= sStr) < 0) - return NULL; - - return virBufferContentAndReset(&buf); -} - - char * virQEMUBuildDriveCommandlineFromJSON(virJSONValue *srcdef) { diff --git a/src/util/virqemu.h b/src/util/virqemu.h index b1fc3c8323..5098ed7653 100644 --- a/src/util/virqemu.h +++ b/src/util/virqemu.h @@ -48,10 +48,6 @@ int virQEMUBuildCommandLineJSON(virJSONValue *value, const char *skipKey, virQEMUBuildCommandLineJSONArrayFormatFunc= array); -char * -virQEMUBuildNetdevCommandlineFromJSON(virJSONValue *props, - bool rawjson); - char *virQEMUBuildDriveCommandlineFromJSON(virJSONValue *src); void virQEMUBuildBufferEscapeComma(virBuffer *buf, const char *str); --=20 2.31.1