From nobody Thu May 2 17:08:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576589672; cv=none; d=zohomail.com; s=zohoarc; b=aa7j8y+E2jt8gccIQetewfJqt4Ash2thHYFZzFggiVaLyLne41xXm1054uX5XKdU314Efq1NVXbbLd9d6IuXU/6ap1adRfhgSWuudor6wtaW459MxU0abz4zDRNdXioldk24Sz6TB/2TCw5QCS0nbO233TT7ST8OMdCEmyJWO6A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576589672; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=LqVyY0gaqB2BHM5xzCG5gafaa16Dx8FWlDLVprYcOpU=; b=RWxZriErMHbSe9vxSsQzYSdbJ4Cwbw/4PrtcDLPgX2k5qsnTggM+ioR+dg4yyb6fUk6Ija0TYdMp0DPJS1MuAxU/jpPcvSRMhsxScRzYdAC+n4QKaI1/s3M219K3EmuuVQyQKyVwrUEx4QbleU9lpWVNMoM99chGx8GVeN7GdXY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1576589672089178.89725633252306; Tue, 17 Dec 2019 05:34:32 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-111-NPNAoR5DNS6rjc1mfYN22w-1; Tue, 17 Dec 2019 08:34:28 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B257C593A1; Tue, 17 Dec 2019 13:34:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0661260BE0; Tue, 17 Dec 2019 13:34:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 024838356E; Tue, 17 Dec 2019 13:34:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBHDYImI024421 for ; Tue, 17 Dec 2019 08:34:18 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8988C2B943; Tue, 17 Dec 2019 13:34:18 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.188]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AF46620BD for ; Tue, 17 Dec 2019 13:34:16 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id DE4C8100269; Tue, 17 Dec 2019 14:34:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576589670; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=LqVyY0gaqB2BHM5xzCG5gafaa16Dx8FWlDLVprYcOpU=; b=BBm0D141Dw1PKLR6Qay9w0abACptmBVn1QmMAoWliBnA//9dKlQWvQW7eBxbhqAOEGhoES wBbGotXy2qVz+YItCgpPBOd70ZNHdCFITRzzllkb1vgZwcfV8R2LR5I1r+lZBk9U5kEF2L sZKrV6wukT4HmFnz8EAt1RWExmC+ANI= From: Jiri Denemark To: libvir-list@redhat.com Date: Tue, 17 Dec 2019 14:34:12 +0100 Message-Id: <64fb940961ccd095bb5eb8c31f4aa3c72d0b2b45.1576589652.git.jdenemar@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] virsh migrate: Require --tls for --tls-destination X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: NPNAoR5DNS6rjc1mfYN22w-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" --tls-destination would be just ignored unless --tls is not specified, which is correct, but let's provide a bit of a guidance is a user forgets to add --tls. https://bugzilla.redhat.com/show_bug.cgi?id=3D1784345 Signed-off-by: Jiri Denemark --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 56137bdd74..e7e92ee60d 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10966,6 +10966,7 @@ cmdMigrate(vshControl *ctl, const vshCmd *cmd) VSH_REQUIRE_OPTION("postcopy-after-precopy", "postcopy"); VSH_REQUIRE_OPTION("timeout-postcopy", "postcopy"); VSH_REQUIRE_OPTION("persistent-xml", "persistent"); + VSH_REQUIRE_OPTION("tls-destination", "tls"); =20 if (!(dom =3D virshCommandOptDomain(ctl, cmd, NULL))) return false; --=20 2.24.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list