From nobody Sun Feb 8 20:34:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598968847; cv=none; d=zohomail.com; s=zohoarc; b=QzeAWAgFSNOSahU2tPoRQb0emsKCsI6s/IAh4sY47s8rW9uyAfjJojAxQuuOnUTcu5ZkwnvBQOqqtBA+RH2sMiKz6/0LbOjqMDG1TmpKBGkeV0bTzAn35SfU7qVV7nHO9ubL/67RHnk/JRiaF2wnqHrBy5SUl3U7fYgO8SFz/cM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598968847; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GfEljaaqZRbHZApuW2bEAYTFSBx1vbpXoGoopZ4SFPk=; b=HbQ2qyQrtVQILpt413lLZyZM20IDx8Ob2swTzBeiz8lOC9+vAtESVbm4ov/INCNUS4GGdQLFVVNaZYfo6osZkHkvVth/TgZmHlgWAkqL/yehQwt/E9kI2Wrtka6MXWNhQshjbxJYTjSdJk+BYMP1tYY33N8tN3LcBpjwFxJt/Bo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1598968847039407.74643364899464; Tue, 1 Sep 2020 07:00:47 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-499-mYtv-vbdOg-_8mOg8N6OMw-1; Tue, 01 Sep 2020 10:00:39 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2466610ABDAF; Tue, 1 Sep 2020 14:00:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7BC75C1BB; Tue, 1 Sep 2020 14:00:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 779827A2E7; Tue, 1 Sep 2020 14:00:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 081E0KsF013108 for ; Tue, 1 Sep 2020 10:00:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id EAC057EB72; Tue, 1 Sep 2020 14:00:20 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6BB887EB91 for ; Tue, 1 Sep 2020 14:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598968843; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GfEljaaqZRbHZApuW2bEAYTFSBx1vbpXoGoopZ4SFPk=; b=UqaL7N9wy3y3rrysQhZiRJE4HzEAWt/IEl4rPk+KWlZcbgS39DRqMmWjrPfyrHBHylyOxw Jr7aL3Mul9FkkxoWi7TWMC848a4gbPR3/8EwQdVzPKj0bjrRZ2wm4BvxGOIJ2SGygZ/Gjz oRY/5M1jOSfUjdSrjE1m+9MXfOP3AvI= X-MC-Unique: mYtv-vbdOg-_8mOg8N6OMw-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/5] virfile.c: Remove some #endif comments Date: Tue, 1 Sep 2020 16:00:11 +0200 Message-Id: <63f00411bfb33a25b71c5ace13fd93e4076e8521.1598968735.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" There are couple of conditional #includes at the beginning of virfile.c and they try to be nice and document #endifs. But they are mostly wrong because either they have the condition in the comment inverted or the comment refers to a different condition than they belong to. Just remove the comments as these #includes are single line mostly. Signed-off-by: Michal Privoznik --- src/util/virfile.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 09658c1623..716bf62593 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -28,19 +28,19 @@ #include #ifndef WIN32 # include -#endif /* !WIN32 */ +#endif #ifdef HAVE_PTY_H /* Linux openpty */ # include -#endif /* !HAVE_PTY_H */ +#endif #ifdef HAVE_UTIL_H /* macOS openpty */ # include -#endif /* !HAVE_LIBUTIL_H */ +#endif #ifdef HAVE_LIBUTIL_H /* FreeBSD openpty */ # include -#endif /* !HAVE_LIBUTIL_H */ +#endif #include #if defined(HAVE_SYS_MOUNT_H) # include --=20 2.26.2