From nobody Sun Apr 28 09:55:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1534424193549741.6320465734483; Thu, 16 Aug 2018 05:56:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6B381821CC; Thu, 16 Aug 2018 12:56:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23F735D9CC; Thu, 16 Aug 2018 12:56:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7C5284A464; Thu, 16 Aug 2018 12:56:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w7GCuSb6001331 for ; Thu, 16 Aug 2018 08:56:28 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3FADC1D083; Thu, 16 Aug 2018 12:56:28 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1C9B1D081 for ; Thu, 16 Aug 2018 12:56:25 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 16 Aug 2018 14:56:23 +0200 Message-Id: <6384e30482c14063a219cb034502f6952ce1d99d.1534424172.git.mprivozn@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [libvirt-glib][PATCH] configure: Drop GLIB2_TEST_REQUIRED X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 16 Aug 2018 12:56:31 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Introduced in eb1f97a4b49a6e it is not needed anymore. The minimal required version of glib is now the same as the one required for tests. This practically reverts the referenced commit. Signed-off-by: Michal Privoznik Reviewed-by: Andrea Bolognani --- configure.ac | 8 +------- tests/Makefile.am | 3 --- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index dd1a85a..adc9e6b 100644 --- a/configure.ac +++ b/configure.ac @@ -13,7 +13,6 @@ LIBVIRT_REQUIRED=3D1.2.5 AC_SUBST([LIBVIRT_REQUIRED]) dnl used in the .spec file GLIB2_REQUIRED=3D2.38.0 AC_SUBST([GLIB2_REQUIRED]) dnl used in the .spec file -GLIB2_TEST_REQUIRED=3D2.38.0 GOBJECT_INTROSPECTION_REQUIRED=3D1.36.0 LIBXML2_REQUIRED=3D2.0.0 =20 @@ -107,17 +106,12 @@ PKG_CHECK_EXISTS(libvirt >=3D 1.2.6, AC_DEFINE([HAVE_VIR_NETWORK_GET_DHCP_LEASES], 1, [Have virNetworkGetD= HCPLeases?]) AC_MSG_RESULT([yes]) ],[AC_MSG_RESULT([no])]) -enable_tests=3Dno -PKG_CHECK_MODULES(GLIB2, glib-2.0 >=3D $GLIB2_TEST_REQUIRED, - [enable_tests=3Dyes], - [PKG_CHECK_MODULES(GLIB2, glib-2.0 >=3D $GLIB2_REQUIRED)= ]) +PKG_CHECK_MODULES(GLIB2, glib-2.0 >=3D $GLIB2_REQUIRED) PKG_CHECK_MODULES(GTHREAD2, gthread-2.0 >=3D $GLIB2_REQUIRED) PKG_CHECK_MODULES(GOBJECT2, gobject-2.0 >=3D $GLIB2_REQUIRED) PKG_CHECK_MODULES(GIO2, gio-2.0 >=3D $GLIB2_REQUIRED) PKG_CHECK_MODULES(LIBXML2, libxml-2.0 >=3D $LIBXML2_REQUIRED) =20 -AM_CONDITIONAL([ENABLE_TESTS], [test "$enable_tests" =3D "yes"]) - LIBVIRT_GLIB_GETTEXT dnl Should be in m4/virt-gettext.m4 but intltoolize is too dnl dumb to find it there diff --git a/tests/Makefile.am b/tests/Makefile.am index 3f4ef6c..2fa847a 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,5 +1,3 @@ -if ENABLE_TESTS - include $(top_srcdir)/build-aux/glib-tap.mk =20 AM_CFLAGS =3D \ @@ -22,4 +20,3 @@ test_programs =3D test-gconfig test-events EXTRA_DIST +=3D \ xml \ $(NULL) -endif --=20 2.16.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list