From nobody Tue Mar 3 04:54:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771245723; cv=none; d=zohomail.com; s=zohoarc; b=mUgOT+IjzFwrgXB7zOIfMg9+xpg/b0Vg5S9vPPq9HFz9H/C3Xjt8+fTRrQDW9LmssYqTmTj46ekAsFH5eDt6u6ChKXs21drr/8xMd+808Q+55/4O+N0pZ1uPUC734vFfl8t8WILgMIBl7UzvWPBAnFZ05+21fL7sBLSTggsv9Go= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771245723; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=dHN2EYne6gfS+daRh4QjvyIFtZw0/m7A4ORT2uB/3V4=; b=MmXlnWrU0ZbkXGvv1OVKaZgkuhNFamlrdOnL5q0z+aUhQ22MU2pPIYzMbBISPgCh2cbbPAOjzmFgc5eQRRmAmLLk1ssgDqKntRnzaieoWbpu+6ltchT4Sue8OUWegkHihgY0+ISOteT7Hl5VJR9Oe5TDefd0pWrGfznGaGBMM28= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 177124572310755.89539098953753; Mon, 16 Feb 2026 04:42:03 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 9953A3FAD0; Mon, 16 Feb 2026 07:42:02 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 8174C41BF5; Mon, 16 Feb 2026 07:33:17 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id C22AF41870; Mon, 16 Feb 2026 07:33:12 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 770BF4196B for ; Mon, 16 Feb 2026 07:28:36 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-BHMnkAdlNHivqbJVrZhxnQ-1; Mon, 16 Feb 2026 07:28:34 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 25B061956053 for ; Mon, 16 Feb 2026 12:28:34 +0000 (UTC) Received: from antique-laptop.rosnicka.net (unknown [10.45.242.10]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 76E0A30001A5 for ; Mon, 16 Feb 2026 12:28:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771244916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dHN2EYne6gfS+daRh4QjvyIFtZw0/m7A4ORT2uB/3V4=; b=CaIxafx8rIkV227w6U6KpznUnqNPh4HGyIqyinR6YuhsOJoJCw5A8PLKPLWvT57Dnbb8VA 0QwK45rNLU/OnDFzFWsrRv6QYLg1KB7UIzt48HpTbGrvNlSndPheso5gW1rhjUJRyIA+dg 22gg7ONh1dJ5ypD/eUosSVv8/Eh92Y4= X-MC-Unique: BHMnkAdlNHivqbJVrZhxnQ-1 X-Mimecast-MFC-AGG-ID: BHMnkAdlNHivqbJVrZhxnQ_1771244914 To: devel@lists.libvirt.org Subject: [libvirt PATCH 14/24] qemuxmlconftest: Rename and refactor testSetupHostdevPrivateData Date: Mon, 16 Feb 2026 13:28:06 +0100 Message-ID: <6316dcdad5930a49c633199cfc80a98d82050b11.1771244723.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: To98A8k9ujUMfPRyCGURamvm_0elbGmW3jJoAhC1M98_1771244914 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KXYYRGEB4E3OXIN76XKRIIMXPKMSXOHG X-Message-ID-Hash: KXYYRGEB4E3OXIN76XKRIIMXPKMSXOHG X-MailFrom: phrdina@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Pavel Hrdina via Devel Reply-To: Pavel Hrdina X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771245725109154100 Content-Type: text/plain; charset="utf-8"; x-default="true" There is no need to call qemuDomainHostdevPrivateNew() because privateData is allocated on creation by virDomainHostdevDefNew(). Signed-off-by: Pavel Hrdina --- tests/qemuxmlconftest.c | 29 +++++++---------------------- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index 321c444d77..a04311647e 100644 --- a/tests/qemuxmlconftest.c +++ b/tests/qemuxmlconftest.c @@ -352,28 +352,13 @@ fakeNetworkPortGetXMLDesc(virNetworkPortPtr port, =20 =20 static void -testSetupHostdevPrivateData(virDomainDef *def) +testQemuPrepareHostdevPCI(virDomainHostdevDef *hostdev) { - size_t i; + qemuDomainHostdevPrivate *hostdevPriv =3D QEMU_DOMAIN_HOSTDEV_PRIVATE(= hostdev); =20 - for (i =3D 0; i < def->nhostdevs; i++) { - virDomainHostdevDef *hostdev =3D def->hostdevs[i]; - - if (hostdev->mode =3D=3D VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && - hostdev->source.subsys.type =3D=3D VIR_DOMAIN_HOSTDEV_SUBSYS_T= YPE_PCI && - hostdev->source.subsys.u.pci.driver.name =3D=3D VIR_DEVICE_HOS= TDEV_PCI_DRIVER_NAME_VFIO && - hostdev->source.subsys.u.pci.driver.iommufd =3D=3D VIR_TRISTAT= E_BOOL_YES) { - - qemuDomainHostdevPrivate *priv; - - if (!hostdev->privateData) { - hostdev->privateData =3D qemuDomainHostdevPrivateNew(); - } - - priv =3D QEMU_DOMAIN_HOSTDEV_PRIVATE(hostdev); - /* Use a placeholder FD value for tests */ - priv->vfioDeviceFd =3D 0; - } + if (virHostdevIsPCIDeviceWithIOMMUFD(hostdev)) { + /* Use a placeholder FD value for tests */ + hostdevPriv->vfioDeviceFd =3D 0; } } =20 @@ -416,6 +401,8 @@ testQemuPrepareHostdev(virDomainObj *vm) testQemuPrepareHostdevUSB(hostdev); break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: + testQemuPrepareHostdevPCI(hostdev); + break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: @@ -479,8 +466,6 @@ testCompareXMLToArgvCreateArgs(virQEMUDriver *drv, if (testQemuPrepareHostBackendChardevOne(NULL, priv->monConfig, vm) < = 0) return NULL; =20 - testSetupHostdevPrivateData(vm->def); - for (i =3D 0; i < vm->def->ndisks; i++) { virDomainDiskDef *disk =3D vm->def->disks[i]; virStorageSource *src; --=20 2.53.0