From nobody Mon Feb 9 02:55:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1586439227; cv=none; d=zohomail.com; s=zohoarc; b=WVg8MgTF5QKqXZLtq6zPromCJd/pCglG1tiYG3M50NnZALdVppU0NJ3Gxonzmw3C7102rsYwbrnEq+O1oZoPaqPQurpLNkENF/fhWJoUIcwVURqvyKKTStO+tf2LBiZZJLJbUIRj3i66zqdP7JnEw5jr9BjZ60Zn27NcIJtV/QI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586439227; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=8jrkpajw7vgdY9opTRI5oQxDZKA2Lz8ltNqpbT6k8s4=; b=FObt+24fVVpH8tU+z/4Hyh5h+qnbEMqdZPYd5796qWHzmOyLb3NOmWuokWyWf+N+uxsuJuNQG0/YXzusI1hsle4kDv9boMTmaba32RMf2GsPL7ahzt+Ozswi/w3uY559a04GDWep9/xKSTMhDjtPTIHv5bfxozFLG3r4SfYTW68= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1586439227481550.9334939518897; Thu, 9 Apr 2020 06:33:47 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-SUkzBfEkNI6RRWHA9BdXhg-1; Thu, 09 Apr 2020 09:33:44 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1FD6C149C7; Thu, 9 Apr 2020 13:33:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 589C69DD8A; Thu, 9 Apr 2020 13:33:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8F47693061; Thu, 9 Apr 2020 13:33:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 039DXWWZ031019 for ; Thu, 9 Apr 2020 09:33:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id A4CCC2CE3A; Thu, 9 Apr 2020 13:33:32 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.40.208.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 14AF25C64E for ; Thu, 9 Apr 2020 13:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586439226; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8jrkpajw7vgdY9opTRI5oQxDZKA2Lz8ltNqpbT6k8s4=; b=i8Ewfq123Mx/JHxSSutrg9to7TzVwJV4h6rlHqAj2G89PytmR1lzCoFsQBDr7nzL0JReew x1Wq977nz813yye67FIglIMr4GMiy280k0ria/BXtfUqp0atntvX97i8d4gbPGpYhKuIqA YbWgsGk7B+Xmobcubcya7AxIpyS8gkQ= X-MC-Unique: SUkzBfEkNI6RRWHA9BdXhg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH] virsh: cmdUndefine: Properly extract delete-storage-volume-snapshots flag Date: Thu, 9 Apr 2020 15:33:27 +0200 Message-Id: <631572a49ed5e459a54ab16aeca47a608f88c5a6.1586439207.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit 86608f787ee added the above flag as an alias for ambiguous 'delete-snapshots' flag, but forgot to actually change the code that extracts it, thus the new version actually doesn't work. https://bugzilla.redhat.com/show_bug.cgi?id=3D1821988 Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 2dc7c38b55..a203b34996 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -3658,7 +3658,7 @@ cmdUndefine(vshControl *ctl, const vshCmd *cmd) bool checkpoints_metadata =3D vshCommandOptBool(cmd, "checkpoints-meta= data"); bool wipe_storage =3D vshCommandOptBool(cmd, "wipe-storage"); bool remove_all_storage =3D vshCommandOptBool(cmd, "remove-all-storage= "); - bool delete_snapshots =3D vshCommandOptBool(cmd, "delete-snapshots"); + bool delete_snapshots =3D vshCommandOptBool(cmd, "delete-storage-volum= e-snapshots"); bool nvram =3D vshCommandOptBool(cmd, "nvram"); bool keep_nvram =3D vshCommandOptBool(cmd, "keep-nvram"); /* Positive if these items exist. */ --=20 2.26.0