From nobody Mon Feb 9 03:54:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1673948304; cv=none; d=zohomail.com; s=zohoarc; b=Y/sL2kgfsJngLIyU2gL6nJy7cdrqgmf9WdTOEAFRN8QAn4KDD6vBctGFFvwUfGL6gYgs56H0FEV01+JRSx80kcX4OH7oI0PKkITnJ0yqMRMTwnblMkElj+OCvldnpybfBhEdsZ4MNjynInh/i5RwaEfUIw3eXH5MgPt4M2Cira0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673948304; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HqxOfazhOuf5b5F4fkjW4+dB+FeOU9XNiA3JPVtjjRw=; b=nEZmIhXiri8vpO1Jfh4BoHW7rVTXwJ+6jqOALKuNQeJe3PcND9FybyZ+f4Fw0SLJ7kXLIQdVjr2aY9Vblxs+8GqGChyXq7uy5/IuHhR73MUVVzp525AWa+tb/WrH9xp6YlMPsCxR0b0yFhNPRaZ4bcZddrFkFOMHx7941JaE+KU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1673948304030986.2588493953014; Tue, 17 Jan 2023 01:38:24 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-271-qIlARNpdPAe9ePvCYpJn-A-1; Tue, 17 Jan 2023 04:37:43 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1BF06801779; Tue, 17 Jan 2023 09:37:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 07E8E492B11; Tue, 17 Jan 2023 09:37:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C8D9619465A4; Tue, 17 Jan 2023 09:37:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 36E601946A45 for ; Tue, 17 Jan 2023 09:37:38 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0A8CD39DB3; Tue, 17 Jan 2023 09:37:38 +0000 (UTC) Received: from localhost.localdomain (ovpn-193-112.brq.redhat.com [10.40.193.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B9FA39D92 for ; Tue, 17 Jan 2023 09:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673948298; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=HqxOfazhOuf5b5F4fkjW4+dB+FeOU9XNiA3JPVtjjRw=; b=EvCl04/LbuWx6uXqLLhjqy/svQ8vlesKdxsfP1V6ifh6KJ/U7C01aSdbnG3XFtZ0h0ucDk TK1RoLwGBz/loVIS1A7h8StU8wPrnNnXbNs6JqImPa7DNZZnN7UsYi2VElIh55u/dzoadZ OyFVAljmueJmB2GWrInk4dnSsRQULp0= X-MC-Unique: qIlARNpdPAe9ePvCYpJn-A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 3/3] docs: document correct cpu shares limits with both cgroups v1 and v2 Date: Tue, 17 Jan 2023 10:37:27 +0100 Message-Id: <6171346f4a6b584cf3f8582ddb182d2d398a9cc0.1673948141.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1673948305100100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The limits are different with cgroups v1 and v2 but our XML documentation and virsh manpage mentioned only cgroups v1 limits without explicitly saying it only applies to cgroups v1. Signed-off-by: Pavel Hrdina --- The "Since 0.9.0" applies to the whole paragraph when the attribute itself was introduced so I figured it would be confusing to add another since to mention when the cgroups v2 support was added. docs/formatdomain.rst | 2 +- docs/manpages/virsh.rst | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 490a954745..8fc8aeb928 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -849,7 +849,7 @@ CPU Tuning There is no unit for the value, it's a relative measure based on the se= tting of other VM, e.g. A VM configured with value 2048 will get twice as muc= h CPU time as a VM configured with value 1024. The value should be in range - [2, 262144]. :since:`Since 0.9.0` + [2, 262144] using cgroups v1, [1, 10000] using cgroups v2. :since:`Sinc= e 0.9.0` ``period`` The optional ``period`` element specifies the enforcement interval (uni= t: microseconds). Within ``period``, each vCPU of the domain will not be a= llowed diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 88b7fa1da8..d5b614dc03 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -4054,7 +4054,8 @@ If *--config* is specified, affect the next start of = a persistent guest. If *--current* is specified, it is equivalent to either *--live* or *--config*, depending on the current state of the guest. =20 -``Note``: The cpu_shares parameter has a valid value range of 2-262144. +``Note``: The cpu_shares parameter has a valid value range of 2-262144 +with cgroups v1, 1-10000 with cgroups v2. =20 ``Note``: The weight and cap parameters are defined only for the XEN_CREDIT scheduler. --=20 2.39.0