From nobody Mon Feb 9 08:34:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600810424; cv=none; d=zohomail.com; s=zohoarc; b=XJR+36Ehc4QaBQJIxmBaYLeLeBqCjMlY1fMwbbSAf5A9Bnsdq5RnMfoBFYXXmfFQ2EWCb398XdD/0SfMijcF5QP1tFuxAbXAmMF6h354W3SIheTKPbvCVGep5CH17/x8YP2kwMeuwIcEx8LKCANMw2/C55OrBgetBCd1ttr/bpc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600810424; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DyRz2ElP1Suo6JvCN77XrNVWW0wuu9XXtzFZG31bAmo=; b=B00wlBBNartjnXIw9Djm2kZmLMnRZXVOXWqofMMLOtVx+M0zVaZiv5+qyLk9CTYAOGPZFWisES5+qVOswmaFT5LelPpmBR8hXjuHhz8y57ovMoefZ9GsnFC1ArTixpjQqudMdWjf95//rP19ws5xAPADKqzVUFwnmgd9AF8ctNk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1600810424932489.27698858384997; Tue, 22 Sep 2020 14:33:44 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-93-PPHkObOeN9KlDzpKFHFf2Q-1; Tue, 22 Sep 2020 17:33:40 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6ABC5800400; Tue, 22 Sep 2020 21:33:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4646D10023A7; Tue, 22 Sep 2020 21:33:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 157758C7D3; Tue, 22 Sep 2020 21:33:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08MLWmdi022719 for ; Tue, 22 Sep 2020 17:32:48 -0400 Received: by smtp.corp.redhat.com (Postfix) id BD1D2100164C; Tue, 22 Sep 2020 21:32:48 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 435D31001901 for ; Tue, 22 Sep 2020 21:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600810423; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DyRz2ElP1Suo6JvCN77XrNVWW0wuu9XXtzFZG31bAmo=; b=WWROzpBPPyOWqueUWt425OUld62uTMHwgkitrAePI36A0M91ssFqyLn6a2sEykeJpiGBId OiEdx4X5DbkYMnndgxTdF9MeK6X4mZbkZy2T0fal5SMpV7xn8M0AzYJxo9oNqA5E+QXXo0 fXEEHhOibus8Ea4cCvESgiPnYSSCaQI= X-MC-Unique: PPHkObOeN9KlDzpKFHFf2Q-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 3/5] rpc: socket: properly call virSetCloseExec Date: Tue, 22 Sep 2020 23:32:31 +0200 Message-Id: <609a5f70495fb295e904a5a082cfa63e0f39b809.1600810297.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) cppcheck reports: style: Argument 'fd<0' to function virSetCloseExec is always 0 [knownArgume= nt] Signed-off-by: J=C3=A1n Tomko Fixes: 4b9919af4024a6fbc3d4ee996d8a4c27dbc44285 --- src/rpc/virnetsocket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index ebdeadc4a0..f79a638775 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -1388,7 +1388,7 @@ int virNetSocketDupFD(virNetSocketPtr sock, bool cloe= xec) } #ifndef F_DUPFD_CLOEXEC if (cloexec && - virSetCloseExec(fd < 0)) { + virSetCloseExec(fd) < 0) { int saveerr =3D errno; closesocket(fd); errno =3D saveerr; --=20 2.26.2