From nobody Mon Feb 9 13:06:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639052469; cv=none; d=zohomail.com; s=zohoarc; b=PcfoIugdVSMWSa+vqyBNchn31FBFd0AeoLA/xJRZveI+TISt6zX5KI5t2CIWD/fE0ELB6xltvHGdKnJSmVMHwvQgGPeH7Epuf1we8u/3ZGMBOsh7eHNAE0z0JEDs0vOgvFb46qyQ1DQuk2s1eewCH5IUkEjBjWr3fntdfGrXWeQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639052469; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=K8IyrxslqrlWy3yo0OSTfHTNoQjNYdlMynmlqjiM4Q4=; b=HbN2vJLk8mIiwy59okSKi3asxFh33XuGTcn+nl8VZTKpAgKla0BHRcqvDNO1EQYBOdkclc8bzGCx6Yoiw5rTZL0rhN6S+gpR5r6/0ybliXl0GABgpZVuk1+6FsCf+Xjo9z7wFoFoooEQZIokS9gYzVjsP2oZI1FZJfKtNIFmYVk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 163905246918361.34835130375086; Thu, 9 Dec 2021 04:21:09 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-587-DGp9Spu8OcKA9wXZ4Gtxhg-1; Thu, 09 Dec 2021 07:20:37 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 15F381006ADC; Thu, 9 Dec 2021 12:20:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D13018462D; Thu, 9 Dec 2021 12:20:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 983714A70A; Thu, 9 Dec 2021 12:20:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B9CKM5N014570 for ; Thu, 9 Dec 2021 07:20:22 -0500 Received: by smtp.corp.redhat.com (Postfix) id EF8F017DBA; Thu, 9 Dec 2021 12:20:21 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 598FA5ED38 for ; Thu, 9 Dec 2021 12:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639052468; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=K8IyrxslqrlWy3yo0OSTfHTNoQjNYdlMynmlqjiM4Q4=; b=R35iC6pEIqWyPxk56FfhEqTUnECX6AE9C3DdKyc9W4/jiohJgNl69FkPhhhLnEIFDczR20 DBMCLmMmcb6jBGI7REgkQSGTLv5tfaDAKFhtyRyKS/vEL5/3ITQH2b6Q94re0S0nwdaL6p tN3vb4XPPN98ipoa94zh8wt2pae3Jz4= X-MC-Unique: DGp9Spu8OcKA9wXZ4Gtxhg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 20/36] util: bitmap: Unexport 'virBitmapParseSeparator' Date: Thu, 9 Dec 2021 13:18:25 +0100 Message-Id: <603e1f120c9c056721cb235b80b2a05b0a61f29f.1639052248.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639052470418100003 Content-Type: text/plain; charset="utf-8" The function isn't used besides tests. Since the separator parsing capability is trivial we can keep it in place and just unexport it for now. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 - src/util/virbitmap.c | 2 +- src/util/virbitmap.h | 5 ----- tests/virbitmaptest.c | 2 +- 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7be5b51100..ac0a704750 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1851,7 +1851,6 @@ virBitmapNextClearBit; virBitmapNextSetBit; virBitmapOverlaps; virBitmapParse; -virBitmapParseSeparator; virBitmapParseUnlimited; virBitmapSetAll; virBitmapSetBit; diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index ee76fec8cd..5f14f1e5e0 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -397,7 +397,7 @@ virBitmapFormat(virBitmap *bitmap) * * Returns 0 on success, or -1 in case of error. */ -int +static int virBitmapParseSeparator(const char *str, char terminator, virBitmap **bitmap, diff --git a/src/util/virbitmap.h b/src/util/virbitmap.h index 026659544e..48074d1ae6 100644 --- a/src/util/virbitmap.h +++ b/src/util/virbitmap.h @@ -81,11 +81,6 @@ int virBitmapParse(const char *str, virBitmap **bitmap, size_t bitmapSize) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int -virBitmapParseSeparator(const char *str, - char terminator, - virBitmap **bitmap, - size_t bitmapSize); virBitmap * virBitmapParseUnlimited(const char *str); diff --git a/tests/virbitmaptest.c b/tests/virbitmaptest.c index 02241c4c20..1794f73f34 100644 --- a/tests/virbitmaptest.c +++ b/tests/virbitmaptest.c @@ -497,7 +497,7 @@ test10(const void *opaque G_GNUC_UNUSED) g_autoptr(virBitmap) b3 =3D NULL; g_autoptr(virBitmap) b4 =3D NULL; - if (virBitmapParseSeparator("0-3,5-8,11-15f16", 'f', &b1, 20) < 0 || + if (virBitmapParse("0-3,5-8,11-15", &b1, 20) < 0 || virBitmapParse("4,9,10,16-19", &b2, 20) < 0 || virBitmapParse("15", &b3, 20) < 0 || virBitmapParse("0,^0", &b4, 20) < 0) --=20 2.31.1