From nobody Mon Apr 29 09:10:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573487820; cv=none; d=zoho.com; s=zohoarc; b=L9GvgcPGIjpfCENii2HOTT2chE6DFtPZhPXv8uGwkuUWJCisUupXQMmaZ1PtmZjIUlUpwEzCZDIxKKum5Vqn9PSLFr57zUt5I7Vom85Ll/TcSJmWJefVqcsayqivLs8zKq50g/fSSaU9y40uCJFUZktfVASWTbe4a3co5hqVYzs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573487820; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=bkP9AFq5wmk6RBZqzwqvVnp8AU8uU2ZBSEHL24L2HIs=; b=JUqRIZ6IUCJrnm1TrlvIeGQQ+VHUC9L7SmxwnCiO2lo5PTGG2D9MOP216FEVr2DDGX/puT/aNypyiBVLLyO3sHDEwywGiLD9u4no5MT74eQyRyPaSAhcIDA7BY7KTLjpxdzAp5l4z9mIgCMJAZKyC6K8FG4C7Nh26Pc1FO0hm5k= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1573487820617460.3723413225632; Mon, 11 Nov 2019 07:57:00 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-183-Bgnab-z5O56WmgWVhFK9Ww-1; Mon, 11 Nov 2019 10:56:57 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 154EB1005510; Mon, 11 Nov 2019 15:56:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF29B1001B2B; Mon, 11 Nov 2019 15:56:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9A3641802027; Mon, 11 Nov 2019 15:56:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xABFupFC025742 for ; Mon, 11 Nov 2019 10:56:51 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5CA9949AF; Mon, 11 Nov 2019 15:56:51 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id DBBDD3DA3 for ; Mon, 11 Nov 2019 15:56:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573487819; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bkP9AFq5wmk6RBZqzwqvVnp8AU8uU2ZBSEHL24L2HIs=; b=a2k6yNX4FWwbRIkBBwPrk8AUV1pvn6nPHXkT5m8zxH5jPmN+bv8EwFFzcV6VNqKJ2wkl0F D8JWWmrZmMZ7C4cVsptYgnYvdMGXJ9utW0dFkMAOnj+4fdOTX0Jf/7RcTwROi9N7GcZ6W7 F9+PO3s//XdVuJZySLXL42SQ2mVO6vA= From: Peter Krempa To: libvir-list@redhat.com Date: Mon, 11 Nov 2019 16:56:47 +0100 Message-Id: <5ff6da09f8a2c1cd9c908128b1eff8826ab9cca7.1573487807.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] qemu: command: Use XML based disk bus convertor in error message X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: Bgnab-z5O56WmgWVhFK9Ww-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The qemu driver has an internal implementation for converting disk bus to string for use with qemu. This should not be used in error messages though as we want to report the string based on the XML value. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f37aecda37..3806cbbaf9 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1303,7 +1303,7 @@ qemuCheckDiskConfig(virDomainDiskDefPtr disk, disk->bus !=3D VIR_DOMAIN_DISK_BUS_SCSI) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("disk device=3D'lun' is not supported for bus= =3D'%s'"), - virDomainDiskQEMUBusTypeToString(disk->bus)); + virDomainDiskBusTypeToString(disk->bus)); return -1; } --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list