From nobody Mon May 6 04:28:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603475111; cv=none; d=zohomail.com; s=zohoarc; b=bxdQh7bsLTypSVMfnOKdvfB7t4Q2+LSXPIz/owxbeJqe8G4ni14zlGh9JjNUOspV3xfqC2Ff/v2Z4+MHt6czgDFE9G7tNxG+zv55NOXoblbxSUj+j5qvGgZx2pDlmEVEkiKgdHLcljH3CGPOru06BoCqSn9X3EFOb8g4AnnnAG0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603475111; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=vQ8YSoZaJrjnhvwciWiweETQ/5A44/ZKBL1zRm8ZnjM=; b=NYlmyaB5sH3NVAtglkM7TVvpw/0CQNma56QXfFacXKq5IberA4zuHcr+V7ZKVTBHBvJZ5Eq67wH+22Gv9JVJ8wtXdwLKh9XLlextt634wQT1P4jU/R6HOhGY02CS81hY+cpsembO3S5vKCHVDNZSBb6vsAdwW2fxyuKyKxgP0aA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1603475111726160.20287503196903; Fri, 23 Oct 2020 10:45:11 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-Hilsd7EPMdKhjsVHhBKR2g-1; Fri, 23 Oct 2020 13:45:08 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8C694804B71; Fri, 23 Oct 2020 17:45:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF7831992D; Fri, 23 Oct 2020 17:45:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0457A92306; Fri, 23 Oct 2020 17:45:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 09NHgldE002021 for ; Fri, 23 Oct 2020 13:42:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id B7BFC75150; Fri, 23 Oct 2020 17:42:47 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31B585576E for ; Fri, 23 Oct 2020 17:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603475110; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vQ8YSoZaJrjnhvwciWiweETQ/5A44/ZKBL1zRm8ZnjM=; b=ZeQDgTQBXqAenvsHg29gVMSoAKKYPoszVm2nUCvQJK3CUss17Zu/oQkeQemnMm2WPSpy6m S5n2XwwYSvjQ+4jcbKZp9V8WvNu6/eC+BXPl9wvZFg5sRT0YtA0TnPLgrc42t3qJjM1W8O fnBhoVLVzmsEQkfsZ699JnjDy4E0A2g= X-MC-Unique: Hilsd7EPMdKhjsVHhBKR2g-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] qemu: Don't pass mode when opening domain log file for reading Date: Fri, 23 Oct 2020 19:42:39 +0200 Message-Id: <5fd674b0e8c782bd3c22a4af9521eb7f7cfa94ee.1603474959.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" In qemuDomainLogContextNew() the domain log file is opened. Twice, the first time for writing, and the second time for reading (if required by caller). When opening the log file for reading a mode is provided. This doesn't do much harm, but is unnecessary. Drop the mode. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 161b369712..d7dbca487a 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6251,7 +6251,7 @@ qemuDomainLogContextPtr qemuDomainLogContextNew(virQE= MUDriverPtr driver, } =20 if (mode =3D=3D QEMU_DOMAIN_LOG_CONTEXT_MODE_START) { - if ((ctxt->readfd =3D open(ctxt->path, O_RDONLY, S_IRUSR | S_I= WUSR)) < 0) { + if ((ctxt->readfd =3D open(ctxt->path, O_RDONLY)) < 0) { virReportSystemError(errno, _("failed to open logfile %s"), ctxt->path); goto error; --=20 2.26.2