From nobody Sun Feb 8 11:59:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618328330; cv=none; d=zohomail.com; s=zohoarc; b=SgMemS986tV/xJ6kFmTzTh3BRntagHogUAeBxSdAarVeV20qHliNEeMjvLMws2WCDoO3x9rJTQQgpsUNjveShjaFn2aqqpffGL+PTVwhD6DB65rIh/UFUVdtrRJw/rxSeWhrYtxD6aCircBSTPL6egVOjy+dfd7sgG+zIlqO47E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618328330; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8p3fsRS5tXAkdd5vLzNqP3EBZ5jivuJ26Ve2OrNj9pY=; b=AiqsEihdDwaseSGwZ+R7xKa9Ae8jIRkplb2B2Hdpudie/s7/ysT5L7l5eKBzCN6v5F7G4/i08aUUQjG2eSnWI9yZy8AesCPaF5L/S0EhjHXasb0wUe8kj7+k7Nie6EyC4sK+dmBdb+CLL3ZjZK8h5GXFxe3S+68/92gyvOScP3Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1618328330919326.3985119270244; Tue, 13 Apr 2021 08:38:50 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-B77WZdM9NSai8FK-r9iiRA-1; Tue, 13 Apr 2021 11:38:46 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0F9D46D24D; Tue, 13 Apr 2021 15:38:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E52BA2B0A9; Tue, 13 Apr 2021 15:38:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AC7A844A5E; Tue, 13 Apr 2021 15:38:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13DFcajh012906 for ; Tue, 13 Apr 2021 11:38:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id A1167226E2; Tue, 13 Apr 2021 15:38:36 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF88C226E0 for ; Tue, 13 Apr 2021 15:38:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618328329; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8p3fsRS5tXAkdd5vLzNqP3EBZ5jivuJ26Ve2OrNj9pY=; b=EEFCQO0aTyAA5m16IZqmxdLCn7bIg2mOwO65Za+D271pnGR6eTwJ2NyeeaQBEt3JWMUZDw itqhtsI7X4c4XOBMdXpHpP+uW+QZuLIDXT+IWh/C/cz8tlp2YR1b836KoUC286wUONp0Go QYREl/VzEWpBiwj8c+dwDn6VjWG2Dm0= X-MC-Unique: B77WZdM9NSai8FK-r9iiRA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [RFC PATCH 3/7] qemuMigrationSrcNBDStorageCopy: Return error code on error Date: Tue, 13 Apr 2021 17:38:23 +0200 Message-Id: <5f017bb40059875df9a3913e211eb72e8fbda1d2.1618328187.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" In case the 'nbdURI' schema is not known the code would report an error but wouldn't return failure. Fixes: 49186372dbe Signed-off-by: Peter Krempa Reviewed-by: Andrea Bolognani --- src/qemu/qemu_migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index df88f954ed..1c3e599128 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1154,6 +1154,7 @@ qemuMigrationSrcNBDStorageCopy(virQEMUDriver *driver, virReportError(VIR_ERR_INVALID_ARG, _("Unsupported scheme in disks URI: %s"), uri->scheme); + return -1; } } --=20 2.30.2