From nobody Sun Apr 28 09:21:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545054675721507.252839229748; Mon, 17 Dec 2018 05:51:15 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6AB2D5F78F; Mon, 17 Dec 2018 13:51:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98CEF5C63F; Mon, 17 Dec 2018 13:51:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2952F3F602; Mon, 17 Dec 2018 13:51:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBHDp7YE029709 for ; Mon, 17 Dec 2018 08:51:07 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7DD0F5C57C; Mon, 17 Dec 2018 13:51:07 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 004A05C635 for ; Mon, 17 Dec 2018 13:51:03 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Mon, 17 Dec 2018 14:50:59 +0100 Message-Id: <5edc3437a6f08e49fa3b2048b8a8531448fb278f.1545054659.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] src: Document autostart for session demon X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 17 Dec 2018 13:51:13 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The autostart under session daemon might not behave as you'd expect it to behave. This patch is inspired by latest libvirt-users discussion: https://www.redhat.com/archives/libvirt-users/2018-December/msg00047.html Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- src/libvirt-domain.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index d49d7f869f..75c9014c0e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -6693,6 +6693,11 @@ virDomainCreateWithFiles(virDomainPtr domain, unsign= ed int nfiles, * configured to be automatically started when the host * machine boots. * + * Please note that this might result in unexpected behaviour if + * used for some session URIs. Since the session daemon is started + * with --timeout it comes and goes and as it does so it + * autostarts domains which might have been shut off recently. + * * Returns -1 in case of error, 0 in case of success */ int --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list