From nobody Thu Mar 28 23:59:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592571331; cv=none; d=zohomail.com; s=zohoarc; b=cRjF2DQqUGuszu7LtOYqynQtDwkEe9V5I5jZf9a/CD1ouf4xFBt/5vWZZdBdbc+ulsArChjr/xf2ni2Qf5pxvP+wyvqmkOIz3PzFY10ASeGbqMh6LbDM6kG8Na/KbB6OLXtgYpoTmjAY+3vNyIsiBsOhflH2aUBbpFIBu39G+sE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592571331; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=FHY0PdveFIisCK/OnJe6YUVYCR//Tl32tQEg7ZtrFEs=; b=U/t3vTtgDq2i8nQ0qB7HvXgc2+Gn79yYZuFobvSj8F2NcVnHE3wSvdgx5O06iCjQpW8KpIBOYu71Zw0bnJmI9A68ihfQqKk7UpAu++ZaNHFARFCGkF+Z6v3COc2P6JK9tqmMdUzWnai/4yf5lFjz/kRFxPcd3zaP9yFxbVI2kGg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1592571331632751.5091938179495; Fri, 19 Jun 2020 05:55:31 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-371-bD7TIFeAObaXufJ0hMYz8A-1; Fri, 19 Jun 2020 08:55:28 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3785107ACCA; Fri, 19 Jun 2020 12:55:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F06345BAD7; Fri, 19 Jun 2020 12:55:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 564141809547; Fri, 19 Jun 2020 12:55:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05JCtEke031057 for ; Fri, 19 Jun 2020 08:55:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9E42B10013C4; Fri, 19 Jun 2020 12:55:14 +0000 (UTC) Received: from nautilus.redhat.com (unknown [10.40.193.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id D55BB1002388; Fri, 19 Jun 2020 12:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592571330; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=FHY0PdveFIisCK/OnJe6YUVYCR//Tl32tQEg7ZtrFEs=; b=hg1X6fbrdhkwZ/SUkcgHV4P2NakJOliYvRObRde9bFhf+7IBML79thRIGnaaDeu3/Ehlus iUHl44w+RTOeKCRyMLg7nERgPjJBL1dU0zVwjCV5JMiOUo9DwNHYNvH+HC7Cqb3bCmNvnC zCN4s0FqUN2h5qTrhbJ8kITlAfK62Ow= X-MC-Unique: bD7TIFeAObaXufJ0hMYz8A-1 From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH] nodedev: Makefile: Use AM_LDFLAGS_MOD_NOUNDEF with the installed library Date: Fri, 19 Jun 2020 14:55:09 +0200 Message-Id: <5ec1f76f5e57fcc04b86aa8e47b5c4a601addd48.1592571245.git.eskultet@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Erik Skultety X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Rather than using the AM_LDFLAGS_MOD_NOUNDEF options with the noinstall library that will come out of libtool from libvirt_driver_nodedev_impl_la, use it with the installed version libvirt_driver_nodedev_la. Broken-by-commit: c44bffb9 Fixes: https://ci.centos.org/job/libvirt-rpm/systems=3Dlibvirt-fedora-32/11= 55/ Signed-off-by: Erik Skultety --- Technically a build fix, but I'd like one more pair of eyes to look at this, especially if they understand libtool. src/node_device/Makefile.inc.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/node_device/Makefile.inc.am b/src/node_device/Makefile.inc= .am index 5993165b56..abe26b23bf 100644 --- a/src/node_device/Makefile.inc.am +++ b/src/node_device/Makefile.inc.am @@ -37,6 +37,7 @@ if WITH_NODE_DEVICES noinst_LTLIBRARIES +=3D libvirt_driver_nodedev_impl.la libvirt_driver_nodedev_la_SOURCES =3D libvirt_driver_nodedev_la_LIBADD =3D libvirt_driver_nodedev_impl.la +libvirt_driver_nodedev_la_LDFLAGS =3D $(AM_LDFLAGS_MOD_NOUNDEF) mod_LTLIBRARIES +=3D libvirt_driver_nodedev.la libvirt_driver_nodedev_impl_la_SOURCES =3D $(NODE_DEVICE_DRIVER_SOURCES) -- 2.26.2