From nobody Wed Dec 17 08:57:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1744032374; cv=none; d=zohomail.com; s=zohoarc; b=kzBV9zJ5QcUC30Q1ZRnSoDGlgCM3h0XUFqD2Xg6ZXiAXIIjcFbeDQu00L9JUytx19mAz7Crp+52MWhHp2hswSZh4sgsjWFoZp7vESvOjPQC4rcu5/vmOz8aRh7LSM8aBxokb2KLNAdxXzybUKwzmGW3+04y3ukpZ0F7jF2+4Tv4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744032374; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=aKZDZGupdU+L3mkErISgw0FiTgHjWleu/6x4ONhvGj8=; b=fZM1CzV4BeFuA0WP9s4c1/zjv/6Gu0DANeSo9KIdq42Ib+iI/eUxSfaUw74HN7wBUqaXnhOSfKlRv50llI0KhDWydV8WY/UU82eE0yuwi7Zc9U8cg1tg3GbnMvmdDLZJJppzU+P0eG+a8svD5ieyOdWSZNEcXjXuRlkdPiN7mN8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1744032374698583.9947017521193; Mon, 7 Apr 2025 06:26:14 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1FB0A1663; Mon, 7 Apr 2025 09:26:14 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 7359A1707; Mon, 7 Apr 2025 09:24:39 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id BBD651295; Mon, 7 Apr 2025 09:24:29 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 42AA911C8 for ; Mon, 7 Apr 2025 09:24:29 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-450-Uod7iizROoOglvBZIgE0kQ-1; Mon, 07 Apr 2025 09:24:27 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E18CA19560BC for ; Mon, 7 Apr 2025 13:24:26 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.8]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D942F1955BC2; Mon, 7 Apr 2025 13:24:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744032269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3uj4j+a0W4zU/+M+RjoZKf+FLTnKyM2DmIcF4wzLek8=; b=BYUzZHe0eW94HWgxJKFrI7wnjjOo1n4gZl29YphRnKUeeCVVPrj6LDPWOMVI0wO4A9coKx ZUBjVHsDCZF/Fp+TrhEKVih6rzJ9q+mQQEflf5+8Nk5eX0xu2Ws2RlTmHaX9/jOgmnjaGf 4v/2DXMOyt8gRxKW1TjmcRi1wsDsbOs= X-MC-Unique: Uod7iizROoOglvBZIgE0kQ-1 X-Mimecast-MFC-AGG-ID: Uod7iizROoOglvBZIgE0kQ_1744032267 To: devel@lists.libvirt.org Subject: [PATCH 4/5] virNodeGetInfo: Improve description of the case when fake data is reported Date: Mon, 7 Apr 2025 15:24:16 +0200 Message-ID: <5ea49340b5c18696a96bb3cc05f359945140c62f.1744032236.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9-cK101mX0LqTn_3IN1exUJtye9E3W8V0phS22PgNBw_1744032267 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KUEMADNDHEUPBADYUOLFGPCPX52M7PCV X-Message-ID-Hash: KUEMADNDHEUPBADYUOLFGPCPX52M7PCV X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Peter Krempa X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744032375751019000 Content-Type: text/plain; charset="utf-8" From: Peter Krempa virNodeGetInfo due to the rigid desing of the filled struct can't faithfully represent all topologies. Improve the description when that happens and outline the fallback topology. The function docs already state that users ought to use virConnectGetCapabilities() instead. Signed-off-by: Peter Krempa --- src/libvirt-host.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/libvirt-host.c b/src/libvirt-host.c index 9845549e36..d82ff993c2 100644 --- a/src/libvirt-host.c +++ b/src/libvirt-host.c @@ -414,10 +414,13 @@ virConnectGetMaxVcpus(virConnectPtr conn, * speed that the first CPU in the machine is currently running at. This s= peed * may vary across CPUs and changes continually as the host OS throttles. * - * The nodes/sockets/cores/threads data is potentially inaccurate as - * it assumes a symmetric installation. If one NUMA node has more - * sockets populated that another NUMA node this information will be - * wrong. It is also not able to report about CPU dies. + * The virNodeInfo structure is not extensible thus only supports global + * nodes/sockets/cores/threads (sockets/cores/threads is per NUMA node) + * topology information. If the host CPU has any further groupings (e.g. + * dies, clusters, etc) or the NUMA topology is non-symmetrical the struct= ure + * can't faithfully represent the system. In such cases a fake topology + * (nodes =3D 1, sockets =3D 1, cores =3D number of host cpus, threads =3D= 1) which + * only correctly represents the total host CPU count is reported. * * Applications are recommended to use the virConnectGetCapabilities() * call instead, which provides all the information except CPU frequency, --=20 2.49.0