From nobody Tue Dec 16 11:44:57 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=smartx.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1739608675212819.041264692576; Sat, 15 Feb 2025 00:37:55 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8E1F51DD2; Sat, 15 Feb 2025 03:37:54 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 9AE6F1EDB; Sat, 15 Feb 2025 03:37:07 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id C9DCA1D13; Sat, 15 Feb 2025 03:37:01 -0500 (EST) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D34901D2E for ; Sat, 15 Feb 2025 03:37:00 -0500 (EST) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2fa4493a695so4177865a91.0 for ; Sat, 15 Feb 2025 00:37:00 -0800 (PST) Received: from Hyman-Dev-Euler.zelin.local ([154.64.226.178]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d55866ecsm39797445ad.212.2025.02.15.00.36.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Feb 2025 00:36:59 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20230601.gappssmtp.com; s=20230601; t=1739608620; x=1740213420; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PFYD4057y7LxCvDjuJboMQ5D85mzqTS+Ngf7gj3Re2k=; b=sac25tgwlRH2JCC239J0dfPkfXSu8hn5n1rElI+djRL2YaYjGYL17iIkYIoqCz7s/h YCTZFm/4E2n7OFbcPJXaWvmRkTkbPqvn1dC71UwfO6Llt1xI7icin1egUpftG7resyiM Wes+WCwpxWgMiAkFNChGs7d8SOk8m+ELjHZu/5laPxPU0zDbFmxjN/wWbFxRkTRucBnz Nv+IpZP6C8cirg/Aoc6EWkBmjByTUYf6tGMjc7gphqUhAsSak5tewjiGjdRg+es5NzVD 96t3uzDxK3KGS0fAJfg80j/JqE3kUco0DXDGG8jiiAJdfxrRHNp3XFQYKun0LTGEimhg UUHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739608620; x=1740213420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PFYD4057y7LxCvDjuJboMQ5D85mzqTS+Ngf7gj3Re2k=; b=ss4Pa0+RGf/42+YqqFtUzOJ8FUtCJIvSdlQxqYPcVW+ZuvvDhqEenA79Hst3fYyyPF Ht8wFwQExXEVFLtCXi3cp5wq4W+5kEe254n5NHjs35JDdBLiTm/2rcsiEZEpkwGI5R+r sXSFKU4yxjipnegJvnW1ST8xuZ0DExRLODTlJg3ekvlaGysVu/u379FcgORiCQadekCd LEIvxN6h7pKOY1sVapTO1ysG+RUFNzQAvorTbTg9nMBQ2Dqm085la9wxTgmcRqXWQBKU SFaP/YMGBqHbNn86da8IecIfJlv4CM7NmP3X9seVbgRJCObi6lt24TxFwM+GBE3H87rh sitg== X-Gm-Message-State: AOJu0Yx7e80PNWi3zyAJUgFZWP773zZQvnFVe0OwL9u8E/Bw7WlMNBFb rPjOM+JCBY36oR0jz4zIfrZ/2dgr37n1Yu4/uhEZVSqvAEoKLo+Fd7mHeeiBTpl9x/yhx9OoIfx EPNTdzQ== X-Gm-Gg: ASbGncsU87j4QuAWfYfVNvWmyiVfLIUdBZP8u4zRvCcXgv6KGn3G0vPimSQSvy5nEAe NOPg9Um2aPSGASXcrZaVrJcdheSPORP2LCqPLlSQ5w8RyntGnkGjaua24AMITqxwON/w4vl70GS SLL7HZgb8EXv8tQSKs2SXU5UG63kPdBA1uMA1Mp7MJUOPOZosp7sR9mQlgxGRTXIeMxvyO1/5bG oUPKV0zH5BJ+OUiwg/gFxRwq2qqkuTDVizMeK72sUL1ZSItUWfrB1C0MmIWXpyDriIJ2TOLZLU/ 0BZAwhqj9/xeFB12EE+lFuPEsV9bQt4V3H2DBpku X-Google-Smtp-Source: AGHT+IFN6F9sGKNnpimZRq/TfwC9qKtKzhauBvU9GdlSQgG2coTQbgyO6P/XeXapxKN4uIM2WlkVAg== X-Received: by 2002:a17:90b:3c0e:b0:2ee:c2df:5d30 with SMTP id 98e67ed59e1d1-2fc41049570mr2969835a91.26.1739608619492; Sat, 15 Feb 2025 00:36:59 -0800 (PST) From: yong.huang@smartx.com To: devel@lists.libvirt.org Subject: [PATCH v1 1/3] libvirt: Add virDomainSetVcpuTuneParameters API Date: Sat, 15 Feb 2025 16:35:51 +0800 Message-Id: <5e4e50e2ecf1764caa3d7068d200c00e7ffc1c50.1739608445.git.yong.huang@smartx.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EYXDO5UFQLEG7HYQLALENLPRHJIGAOLP X-Message-ID-Hash: EYXDO5UFQLEG7HYQLALENLPRHJIGAOLP X-MailFrom: yong.huang@smartx.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: yong.huang@smartx.com X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1739608676465019000 Content-Type: text/plain; charset="utf-8" From: Hyman Huang Introduce virDomainSetVcpuTuneParameters API to support tunables of virtual CPUs. Signed-off-by: Hyman Huang --- include/libvirt/libvirt-domain.h | 13 ++++++++ src/driver-hypervisor.h | 8 +++++ src/libvirt-domain.c | 56 ++++++++++++++++++++++++++++++++ src/libvirt_public.syms | 5 +++ src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 20 +++++++++++- 6 files changed, 102 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-dom= ain.h index f5420bca6e..ae1e07b7b6 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -6612,4 +6612,17 @@ virDomainGraphicsReload(virDomainPtr domain, unsigned int type, unsigned int flags); =20 +/** + * virDomainSetVcpuTuneParameters: + * + * Set virtual CPU tunables for the domain + * + * Since: 11.1.0 + */ +int +virDomainSetVcpuTuneParameters(virDomainPtr domain, + const char *vcpumap, + virTypedParameterPtr params, + int nparams, + unsigned int flags); #endif /* LIBVIRT_DOMAIN_H */ diff --git a/src/driver-hypervisor.h b/src/driver-hypervisor.h index 4ce8da078d..b8b8d53311 100644 --- a/src/driver-hypervisor.h +++ b/src/driver-hypervisor.h @@ -1453,6 +1453,13 @@ typedef int unsigned int type, unsigned int flags); =20 +typedef int +(*virDrvDomainSetVcpuTuneParameters)(virDomainPtr domain, + const char *vcpumap, + virTypedParameterPtr params, + int nparams, + unsigned int flags); + typedef struct _virHypervisorDriver virHypervisorDriver; =20 /** @@ -1726,4 +1733,5 @@ struct _virHypervisorDriver { virDrvDomainStartDirtyRateCalc domainStartDirtyRateCalc; virDrvDomainFDAssociate domainFDAssociate; virDrvDomainGraphicsReload domainGraphicsReload; + virDrvDomainSetVcpuTuneParameters domainSetVcpuTuneParameters; }; diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 072cc32255..90d02a2f06 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -14162,3 +14162,59 @@ virDomainGraphicsReload(virDomainPtr domain, virDispatchError(domain->conn); return -1; } + + +/** + * virDomainSetVcpuTuneParameters: + * @domain: pointer to domain object + * @vcpumap: text representation of a bitmap of vcpus to set + * @params: pointer to virtual CPU parameter objects + * @nparams: number of virtual CPU tunable parameter + * @flags: bitwise-OR of virDomainModificationImpact + * + * Change all or a subset of the virtual CPU tunables. + * + * Returns 0 in case of success, -1 in case of failure. + * + * Since: 11.1.0 + */ +int +virDomainSetVcpuTuneParameters(virDomainPtr domain, + const char *vcpumap, + virTypedParameterPtr params, + int nparams, + unsigned int flags) +{ + virConnectPtr conn; + + VIR_DOMAIN_DEBUG(domain, "vcpumap=3D'%s', params=3D%p, nparams=3D%d, f= lags=3D0x%x", + vcpumap, params, nparams, flags); + + virResetLastError(); + + virCheckDomainReturn(domain, -1); + conn =3D domain->conn; + + virCheckReadOnlyGoto(conn->flags, error); + virCheckNonNullArgGoto(vcpumap, error); + virCheckNonNullArgGoto(params, error); + virCheckPositiveArgGoto(nparams, error); + + if (virTypedParameterValidateSet(conn, params, nparams) < 0) + goto error; + + if (conn->driver->domainSetVcpuTuneParameters) { + int ret; + ret =3D conn->driver->domainSetVcpuTuneParameters(domain, vcpumap,= params, + nparams, flags); + if (ret < 0) + goto error; + return ret; + } + + virReportUnsupportedError(); + + error: + virDispatchError(domain->conn); + return -1; +} diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms index 7a3492d9d7..65d684b58b 100644 --- a/src/libvirt_public.syms +++ b/src/libvirt_public.syms @@ -948,4 +948,9 @@ LIBVIRT_10.2.0 { virDomainGraphicsReload; } LIBVIRT_10.1.0; =20 +LIBVIRT_11.1.0 { + global: + virDomainSetVcpuTuneParameters; +} LIBVIRT_10.2.0; + # .... define new API here using predicted next version number .... diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 307f9ca945..eb3a47ef75 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -7835,6 +7835,7 @@ static virHypervisorDriver hypervisor_driver =3D { .domainSetLaunchSecurityState =3D remoteDomainSetLaunchSecurityState, = /* 8.0.0 */ .domainFDAssociate =3D remoteDomainFDAssociate, /* 9.0.0 */ .domainGraphicsReload =3D remoteDomainGraphicsReload, /* 10.2.0 */ + .domainSetVcpuTuneParameters =3D remoteDomainSetVcpuTuneParameters, /*= 11.1.0 */ }; =20 static virNetworkDriver network_driver =3D { diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index 41c045ff78..f99f44c9b5 100644 --- a/src/remote/remote_protocol.x +++ b/src/remote/remote_protocol.x @@ -292,6 +292,9 @@ const REMOTE_DOMAIN_AUTHORIZED_SSH_KEYS_MAX =3D 2048; /* Upper limit on number of messages */ const REMOTE_DOMAIN_MESSAGES_MAX =3D 2048; =20 +/* Upper limit on VCPU tunable parameters. */ +const REMOTE_DOMAIN_SET_VCPU_TUNE_PARAMETERS_MAX =3D 16; + =20 /* UUID. VIR_UUID_BUFLEN definition comes from libvirt.h */ typedef opaque remote_uuid[VIR_UUID_BUFLEN]; @@ -3973,6 +3976,13 @@ struct remote_domain_fd_associate_args { remote_nonnull_string name; unsigned int flags; }; + +struct remote_domain_set_vcpu_tune_parameters_args { + remote_nonnull_domain dom; + remote_nonnull_string cpumap; + remote_typed_param params; + unsigned int flags; +}; /*----- Protocol. -----*/ =20 /* Define the program number, protocol version and procedure numbers here.= */ @@ -7048,5 +7058,13 @@ enum remote_procedure { * @generate: both * @acl: domain:write */ - REMOTE_PROC_DOMAIN_GRAPHICS_RELOAD =3D 448 + REMOTE_PROC_DOMAIN_GRAPHICS_RELOAD =3D 448, + + /** + * @generate: both + * @acl: domain:write + * @acl: domain:save:!VIR_DOMAIN_AFFECT_CONFIG|VIR_DOMAIN_AFFECT_LIVE + * @acl: domain:save:VIR_DOMAIN_AFFECT_CONFIG + */ + REMOTE_PROC_DOMAIN_SET_VCPU_TUNE_PARAMETERS =3D 449 }; --=20 2.27.0