From nobody Sat May 11 09:02:58 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1708593400146591.019836899622; Thu, 22 Feb 2024 01:16:40 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id C90881BC7; Thu, 22 Feb 2024 04:16:38 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D1DA517E5; Thu, 22 Feb 2024 04:15:32 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 11C2F187A; Thu, 22 Feb 2024 04:15:28 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8168317E5 for ; Thu, 22 Feb 2024 04:15:27 -0500 (EST) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-nMS6C1XXPkGF2Y_kFP8IOw-1; Thu, 22 Feb 2024 04:15:25 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6C27B299E763 for ; Thu, 22 Feb 2024 09:15:25 +0000 (UTC) Received: from ajulis-thinkpadt14gen4.remote.csb (unknown [10.43.3.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id 13C981BDD1 for ; Thu, 22 Feb 2024 09:15:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: nMS6C1XXPkGF2Y_kFP8IOw-1 From: Adam Julis To: devel@lists.libvirt.org Subject: [PATCH] virfile: switch to virReportSystemError in VIR_CLOSE() cond. Date: Thu, 22 Feb 2024 10:14:35 +0100 Message-ID: <5d90c757dbffe8a78a87fb833e484910d400b2c0.1708593249.git.ajulis@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: SRMVSFFED6R3XMLUISMR3ZZBQVNBN24A X-Message-ID-Hash: SRMVSFFED6R3XMLUISMR3ZZBQVNBN24A X-MailFrom: ajulis@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1708593401530100001 VIR_CLOSE also set errno, so it's not nessesary use virReportError with exp= licit error code Signed-off-by: Adam Julis Reviewed-by: Michal Privoznik --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 9463833d31..deaf4555fd 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -467,7 +467,7 @@ virFileWrapperFdNew(int *fd, const char *name, unsigned= int flags) goto error; =20 if (VIR_CLOSE(pipefd[!output]) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("unable to close pi= pe")); + virReportSystemError(errno, "%s", _("unable to close pipe")); goto error; } =20 --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org